From: "jack_wang" <jack_wang@usish.com>
To: "Julia Lawall" <julia@diku.dk>,
"lindar_liu" <lindar_liu@usish.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
"linux-scsi" <linux-scsi@vger.kernel.org>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
"kernel-janitors" <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 5/7] drivers/scsi/pm8001: Use kzalloc for allocating onlyone thing
Date: Sat, 19 Dec 2009 22:08:11 +0800 [thread overview]
Message-ID: <200912192208103123212@usish.com> (raw)
In-Reply-To: Pine.LNX.4.64.0912190817110.30546@ask.diku.dk
RE:[PATCH 5/7] drivers/scsi/pm8001: Use kzalloc for allocating onlyone thing
From: Julia Lawall <julia@diku.dk>
Use kzalloc rather than kcalloc(1,...)
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
@@
- kcalloc(1,
+ kzalloc(
...)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/scsi/pm8001/pm8001_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
--- a/drivers/scsi/pm8001/pm8001_init.c 2009-12-12 00:23:19.000000000 +0100
+++ b/drivers/scsi/pm8001/pm8001_init.c 2009-12-19 07:52:44.000000000 +0100
@@ -654,7 +654,7 @@ static int __devinit pm8001_pci_probe(st
}
chip = &pm8001_chips[ent->driver_data];
SHOST_TO_SAS_HA(shost) =
- kcalloc(1, sizeof(struct sas_ha_struct), GFP_KERNEL);
+ kzalloc(sizeof(struct sas_ha_struct), GFP_KERNEL);
if (!SHOST_TO_SAS_HA(shost)) {
rc = -ENOMEM;
goto err_out_free_host;
[Jack]Acked-by:Jack Wang <jack_wang@usish.com>
Thanks, Julia
prev parent reply other threads:[~2009-12-19 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-19 7:17 [PATCH 5/7] drivers/scsi/pm8001: Use kzalloc for allocating only one thing Julia Lawall
2009-12-19 14:08 ` [PATCH 5/7] drivers/scsi/pm8001: Use kzalloc for allocating onlyone thing jack_wang
2009-12-19 14:08 ` jack_wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912192208103123212@usish.com \
--to=jack_wang@usish.com \
--cc=James.Bottomley@suse.de \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=lindar_liu@usish.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox