From: Willy Tarreau <w@1wt.eu>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Michal Marek <mmarek@suse.cz>,
Michael Guntsche <mike@it-loops.com>,
Oliver Hartkopp <oliver@hartkopp.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
mjt@tls.msk.ru
Subject: Re: [PATCH] kbuild: correct size calculation of bzImgae / fix x86 boot
Date: Sun, 20 Dec 2009 11:28:57 +0100 [thread overview]
Message-ID: <20091220102857.GG32739@1wt.eu> (raw)
In-Reply-To: <20091220100344.GA6614@merkur.ravnborg.org>
On Sun, Dec 20, 2009 at 11:03:44AM +0100, Sam Ravnborg wrote:
> We use ... printf \x ... when calculating the size of the
> compressed kernel.
> Unfortunately dash built-in printf does not support this notation
> resulting in a non-bootable kernel.
>
> Fix this by always using the external version of printf.
Do we really want to workaround shells bugs ? I mean, either
the shell correctly implements the printf function or it does
not at all so that the correct printf is found in the path.
"man printf" clearly states that \x is supported, so what
should be fixed is the shell's implementation of printf.
The more absolute paths we specify, the less portable the
build system. And if linking /bin/sh to whatever shell works
but linking it to dash breaks, it's a shell bug.
Willy
next prev parent reply other threads:[~2009-12-20 10:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-19 23:34 2.6.33-rc1 Reboot right after bootloader Michael Guntsche
2009-12-20 8:46 ` Sam Ravnborg
2009-12-20 9:10 ` Johannes Stezenbach
2009-12-20 10:38 ` Michael Tokarev
2009-12-20 11:10 ` Michael Tokarev
2009-12-20 11:38 ` Michael Tokarev
2009-12-20 9:11 ` Michael Guntsche
2009-12-20 10:03 ` [PATCH] kbuild: correct size calculation of bzImgae / fix x86 boot Sam Ravnborg
2009-12-20 10:20 ` Oliver Hartkopp
2009-12-20 10:28 ` Willy Tarreau [this message]
2009-12-20 10:47 ` Michael Tokarev
2009-12-20 13:09 ` Willy Tarreau
2009-12-20 11:19 ` Michael Tokarev
2009-12-20 12:02 ` Andreas Schwab
2009-12-20 12:18 ` Sam Ravnborg
2009-12-21 12:23 ` Michal Marek
2009-12-21 13:50 ` Andreas Schwab
2009-12-20 14:11 ` Sam Ravnborg
2009-12-21 14:17 ` Michal Marek
2009-12-21 16:28 ` Michael Guntsche
2009-12-21 19:53 ` Michael Tokarev
2009-12-21 20:48 ` Michael Guntsche
2009-12-21 18:28 ` H. Peter Anvin
2009-12-21 19:09 ` H. Peter Anvin
2009-12-20 13:50 ` Arkadiusz Miskiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091220102857.GG32739@1wt.eu \
--to=w@1wt.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@it-loops.com \
--cc=mjt@tls.msk.ru \
--cc=mmarek@suse.cz \
--cc=oliver@hartkopp.net \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox