From: Alex Chiang <achiang@hp.com>
To: venkatesh.pallipadi@intel.com, lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 08/11] ACPI: processor: change acpi_processor_eval_pdc interface
Date: Sun, 20 Dec 2009 12:31:04 -0700 [thread overview]
Message-ID: <20091220193104.5545.76084.stgit@bob.kio> (raw)
In-Reply-To: <20091220192731.5545.20582.stgit@bob.kio>
acpi_processor_eval_pdc() really only needs a handle and an
acpi_object_list * to do its work.
No need to pass in a struct acpi_processor *, so let's be more specific
about what we want.
Signed-off-by: Alex Chiang <achiang@hp.com>
---
drivers/acpi/processor_pdc.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/acpi/processor_pdc.c b/drivers/acpi/processor_pdc.c
index 23d2828..974de4e 100644
--- a/drivers/acpi/processor_pdc.c
+++ b/drivers/acpi/processor_pdc.c
@@ -97,13 +97,11 @@ static struct acpi_object_list *acpi_processor_alloc_pdc(void)
* _PDC is required for a BIOS-OS handshake for most of the newer
* ACPI processor features.
*/
-static int acpi_processor_eval_pdc(struct acpi_processor *pr)
+static int
+acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in)
{
- struct acpi_object_list *pdc_in = pr->pdc;
acpi_status status = AE_OK;
- if (!pdc_in)
- return status;
if (idle_nomwait) {
/*
* If mwait is disabled for CPU C-states, the C2C3_FFH access
@@ -118,7 +116,7 @@ static int acpi_processor_eval_pdc(struct acpi_processor *pr)
buffer[2] &= ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH);
}
- status = acpi_evaluate_object(pr->handle, "_PDC", pdc_in, NULL);
+ status = acpi_evaluate_object(handle, "_PDC", pdc_in, NULL);
if (ACPI_FAILURE(status))
ACPI_DEBUG_PRINT((ACPI_DB_INFO,
@@ -148,9 +146,7 @@ void acpi_processor_set_pdc(struct acpi_processor *pr)
if (!obj_list)
return;
- pr->pdc = obj_list;
-
- acpi_processor_eval_pdc(pr);
+ acpi_processor_eval_pdc(pr->handle, obj_list);
acpi_processor_cleanup_pdc(pr);
}
EXPORT_SYMBOL_GPL(acpi_processor_set_pdc);
next prev parent reply other threads:[~2009-12-20 19:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 19:30 [PATCH v2 00/11] ACPI: early _PDC eval and unify x86/ia64 Alex Chiang
2009-12-20 19:30 ` [PATCH v2 01/11] ACPI: processor: call _PDC early Alex Chiang
2009-12-21 1:34 ` Lin Ming
2009-12-21 2:19 ` Alex Chiang
2009-12-20 19:30 ` [PATCH v2 02/11] ACPI: processor: introduce arch_has_acpi_pdc Alex Chiang
2009-12-20 19:30 ` [PATCH v2 03/11] ACPI: processor: unify arch_acpi_processor_init_pdc Alex Chiang
2009-12-20 19:30 ` [PATCH v2 04/11] ACPI: processor: factor out common _PDC settings Alex Chiang
2009-12-20 19:30 ` [PATCH v2 05/11] ACPI: processor: finish unifying arch_acpi_processor_init_pdc() Alex Chiang
2009-12-20 19:30 ` [PATCH v2 06/11] ACPI: processor: unify arch_acpi_processor_cleanup_pdc Alex Chiang
2009-12-20 19:30 ` [PATCH v2 07/11] ACPI: processor: introduce acpi_processor_alloc_pdc() Alex Chiang
2009-12-20 19:31 ` Alex Chiang [this message]
2009-12-20 19:31 ` [PATCH v2 09/11] ACPI: processor: open code acpi_processor_cleanup_pdc Alex Chiang
2009-12-20 19:31 ` [PATCH v2 10/11] ACPI: processor: change acpi_processor_set_pdc() interface Alex Chiang
2009-12-20 19:31 ` [PATCH v2 11/11] ACPI: processor: remove _PDC object list from struct acpi_processor Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091220193104.5545.76084.stgit@bob.kio \
--to=achiang@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox