From: tytso@mit.edu
To: Ingo Molnar <mingo@elte.hu>
Cc: Joe Perches <joe@perches.com>,
mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, peterz@infradead.org,
efault@gmx.de, akpm@linux-foundation.org, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/urgent] sched: Restore printk sanity
Date: Sun, 20 Dec 2009 17:12:32 -0500 [thread overview]
Message-ID: <20091220221232.GC4887@thunk.org> (raw)
In-Reply-To: <20091220191531.GA17878@elte.hu>
On Sun, Dec 20, 2009 at 08:15:31PM +0100, Ingo Molnar wrote:
>
> It's also needlessly broken mid-string. Checkpatch should warn about printk
> lines that end with a '"', those are almost always a sign of some ill-advised
> break-the-string artifact.
Ironic, given that for a long time checkpatch strongly encouraged
people to do this with its "line too long" complaint. Maybe all
printk's should be exempted from this, or at least if it's the format
string which is breaking whatever the magic boundary happens to be?
Even if we up the limit to 106, or 132, or whatever, I can imagine
situations where it will be *impossible* to shut up checkpatch.
Either it will bitch and moan about the line being too long, or it
will bitch and moan that a format string has been broken across
multiple lines. :-(
- Ted
next prev parent reply other threads:[~2009-12-20 22:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 13:23 sched: restore sanity Peter Zijlstra
2009-12-20 14:27 ` Arjan van de Ven
2009-12-20 14:49 ` Ingo Molnar
2009-12-20 14:51 ` Peter Zijlstra
[not found] ` <236ccac0912200703g464912b1r421497ebf3b6ebc6@mail.gmail.com>
2009-12-20 15:05 ` San Mehat
2009-12-20 15:19 ` Peter Zijlstra
2009-12-20 15:28 ` Mike Galbraith
2009-12-20 15:36 ` San Mehat
2009-12-20 17:22 ` Joe Perches
2009-12-20 17:36 ` Peter Zijlstra
2009-12-20 17:50 ` Ingo Molnar
2009-12-20 17:57 ` Joe Perches
2009-12-20 17:37 ` Ingo Molnar
2009-12-20 18:17 ` Arjan van de Ven
2009-12-20 18:21 ` Joe Perches
2009-12-21 0:48 ` Arjan van de Ven
2009-12-21 1:20 ` Joe Perches
2009-12-22 10:11 ` Al Viro
2009-12-20 17:22 ` Joe Perches
2009-12-20 18:00 ` [tip:sched/urgent] sched: Restore printk sanity tip-bot for Peter Zijlstra
2009-12-20 20:36 ` Geert Uytterhoeven
2009-12-21 20:40 ` Valdis.Kletnieks
2009-12-25 13:26 ` Pavel Machek
[not found] ` <1261756819.4937.216.camel@laptop>
2009-12-25 18:39 ` Joe Perches
2009-12-25 18:47 ` Pavel Machek
2009-12-25 18:45 ` Ingo Molnar
2009-12-27 0:45 ` Valdis.Kletnieks
2009-12-27 5:56 ` Ingo Molnar
2009-12-20 18:06 ` tip-bot for Peter Zijlstra
2009-12-20 18:55 ` Joe Perches
2009-12-20 19:15 ` Ingo Molnar
2009-12-20 19:44 ` [PATCH] scripts/checkpatch.pl: Add WARN on printk format split on multiple lines Joe Perches
2009-12-20 20:10 ` Ingo Molnar
2009-12-20 22:12 ` tytso [this message]
2009-12-21 1:11 ` [tip:sched/urgent] sched: Restore printk sanity Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091220221232.GC4887@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=efault@gmx.de \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox