From: Ingo Molnar <mingo@elte.hu>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: Fix lockdep warning in global_clock()
Date: Mon, 21 Dec 2009 07:43:56 +0100 [thread overview]
Message-ID: <20091221064356.GA2378@elte.hu> (raw)
In-Reply-To: <4B2F1543.8020300@cn.fujitsu.com>
* Li Zefan <lizf@cn.fujitsu.com> wrote:
> # echo 1 > events/enable
> # echo global > trace_clock
>
> ------------[ cut here ]------------
> WARNING: at kernel/lockdep.c:3162 check_flags+0xb2/0x190()
> ...
> ---[ end trace 3f86734a89416623 ]---
> possible reason: unannotated irqs-on.
> ...
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
> kernel/trace/trace_clock.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace_clock.c b/kernel/trace/trace_clock.c
> index 84a3a7b..11563c9 100644
> --- a/kernel/trace/trace_clock.c
> +++ b/kernel/trace/trace_clock.c
> @@ -83,7 +83,7 @@ u64 notrace trace_clock_global(void)
> int this_cpu;
> u64 now;
>
> - raw_local_irq_save(flags);
> + local_irq_save(flags);
Hm, wont this cause problems when we trace inside lockdep? Have you tried the
lockdep events - do they still work?
Ingo
next prev parent reply other threads:[~2009-12-21 6:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 6:27 [PATCH] tracing: Fix lockdep warning in global_clock() Li Zefan
2009-12-21 6:43 ` Ingo Molnar [this message]
2009-12-21 7:36 ` Li Zefan
2009-12-21 14:40 ` Peter Zijlstra
2009-12-21 15:56 ` Steven Rostedt
2009-12-22 5:17 ` Li Zefan
2009-12-22 6:16 ` Yong Zhang
2009-12-22 8:23 ` Peter Zijlstra
2009-12-23 0:59 ` Li Zefan
2009-12-21 15:49 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091221064356.GA2378@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox