From: Andi Kleen <andi@firstfloor.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: andi@firstfloor.org, linux-kernel@vger.kernel.org,
ebiederm@xmission.com, paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH] [0/11] SYSCTL: Use RCU to avoid races with string sysctls
Date: Mon, 21 Dec 2009 11:50:10 +0100 [thread overview]
Message-ID: <20091221105010.GC25372@basil.fritz.box> (raw)
In-Reply-To: <b6fcc0a0912202357g269722f2ra2cb136396e8186e@mail.gmail.com>
On Mon, Dec 21, 2009 at 09:57:32AM +0200, Alexey Dobriyan wrote:
> > new = alloc_rcu_string(MAX_GLOBAL_SIZE, GFP_KERNEL);
>
> I think adding failure mode is not right.
> We can get away with per-sysctl-string spinlock and not introduce yet
> another API.
You mean when running out of memory here?
When this runs out of memory the system will be not usable anyways
and on the last legs and likely in a deadly swap storm.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-12-21 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 7:57 [PATCH] [0/11] SYSCTL: Use RCU to avoid races with string sysctls Alexey Dobriyan
2009-12-21 10:50 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-12-21 1:20 Andi Kleen
2009-12-21 1:59 ` Eric W. Biederman
2009-12-21 2:04 ` Andi Kleen
2009-12-21 2:31 ` Eric W. Biederman
2009-12-21 3:21 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091221105010.GC25372@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=adobriyan@gmail.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox