From: Christoph Hellwig <hch@infradead.org>
To: Steven Whitehouse <swhiteho@redhat.com>
Cc: Thiago Farina <tfransosi@gmail.com>,
linux-kernel@vger.kernel.org,
Benjamin Marzinski <bmarzins@redhat.com>,
David Teigland <teigland@redhat.com>,
cluster-devel@redhat.com
Subject: Re: [PATCH 2/2] gfs2: Use CALLER_ADDR0 macro.
Date: Mon, 21 Dec 2009 08:43:44 -0500 [thread overview]
Message-ID: <20091221134344.GA17372@infradead.org> (raw)
In-Reply-To: <1261387361.2200.6.camel@localhost>
On Mon, Dec 21, 2009 at 09:22:41AM +0000, Steven Whitehouse wrote:
> Hi,
>
> Looks fairly harmless, even though I don't entirely see the point. Do
> you want me to add this to me tree?
We also have a _RET_IP_ macro that does the same and has a much more
useful name. And given that we need the address as void pointer to
print it using our printk extension both seem a bit supoptimal.
Given that a lot of tracing code needs this a bit of standardization
would be useful - more important for the type to store the address than
just the macro name.
next prev parent reply other threads:[~2009-12-21 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 18:07 [PATCH 1/2] kernel: Use CALLER_ADDR0 macro Thiago Farina
2009-12-20 18:07 ` [PATCH 2/2] gfs2: " Thiago Farina
2009-12-21 9:22 ` Steven Whitehouse
2009-12-21 13:43 ` Christoph Hellwig [this message]
2009-12-20 19:03 ` [PATCH 1/2] kernel: " Andi Kleen
2009-12-28 10:10 ` [tip:core/cleanups] " tip-bot for Thiago Farina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091221134344.GA17372@infradead.org \
--to=hch@infradead.org \
--cc=bmarzins@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swhiteho@redhat.com \
--cc=teigland@redhat.com \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox