From: Oleg Nesterov <oleg@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
Roland McGrath <roland@redhat.com>
Subject: Re: BKL use in ptrace
Date: Mon, 21 Dec 2009 18:02:37 +0100 [thread overview]
Message-ID: <20091221170237.GA5384@redhat.com> (raw)
In-Reply-To: <20091220185318.GA15989@basil.fritz.box>
(add Roland)
On 12/20, Andi Kleen wrote:
>
> ptrace has this comment/BKL use:
>
> /*
> * This lock_kernel fixes a subtle race with suid exec
> */
> lock_kernel();
>
> But unless I'm blind I don't see execve actually getting the BKL
> anywhere. So is this comment outdated or misleading (is the race with exit?)
> or is there a bug?
I never understood this lock_kernel().
In any case it looks outdated. We were going to kill it "soon",
along with other ptrace changes.
Oleg.
next prev parent reply other threads:[~2009-12-21 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 18:53 BKL use in ptrace Andi Kleen
2009-12-21 17:02 ` Oleg Nesterov [this message]
2009-12-22 1:13 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091221170237.GA5384@redhat.com \
--to=oleg@redhat.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox