From: Arnd Bergmann <arnd@arndb.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
jbeulich@novell.com, rusty@rustcorp.com.au, rguenther@suse.de
Subject: Re: [PATCH] Fix BUILD_BUG_ON in fs/compat_ioctl.c to build with gcc 4.5 snapshot
Date: Mon, 21 Dec 2009 17:48:12 +0100 [thread overview]
Message-ID: <200912211748.13017.arnd@arndb.de> (raw)
In-Reply-To: <20091220165315.GA13208@basil.fritz.box>
On Sunday 20 December 2009, Andi Kleen wrote:
> ===================================================================
> --- linux-2.6.33-rc1-ak.orig/fs/compat_ioctl.c
> +++ linux-2.6.33-rc1-ak/fs/compat_ioctl.c
> @@ -1649,8 +1649,10 @@ static int compat_ioctl_check_table(unsi
> {
> int i;
> const int max = ARRAY_SIZE(ioctl_pointer) - 1;
> + extern void __ioctl_pointer_too_large(void);
>
> - BUILD_BUG_ON(max >= (1 << 16));
> + if (max >= (1 << 16))
> + __ioctl_pointer_too_large();
>
> /* guess initial offset into table, assuming a
> normalized distribution */
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2009-12-21 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 16:53 [PATCH] Fix BUILD_BUG_ON in fs/compat_ioctl.c to build with gcc 4.5 snapshot Andi Kleen
2009-12-21 10:32 ` Rusty Russell
2009-12-21 10:51 ` Andi Kleen
2009-12-21 23:44 ` Rusty Russell
2009-12-22 0:13 ` Andi Kleen
2009-12-21 16:48 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912211748.13017.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=andi@firstfloor.org \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rguenther@suse.de \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox