From: Rusty Russell <rusty@rustcorp.com.au>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Helge Deller <deller@gmx.de>, Martin Michlmayr <tbm@cyrius.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] modules: Skip empty sections when exporting section notes
Date: Mon, 21 Dec 2009 20:54:48 +1030 [thread overview]
Message-ID: <200912212054.48469.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1261233781.2418.87.camel@localhost>
On Sun, 20 Dec 2009 01:13:01 am Ben Hutchings wrote:
> Commit 35dead4 "modules: don't export section names of empty sections
> via sysfs" changed the set of sections that have attributes, but did
> not change the iteration over these attributes in add_notes_attrs().
> This can lead to add_notes_attrs() creating attributes with the wrong
> names or with null name pointers.
>
> Introduce a sect_empty() function and use it in both add_sect_attrs()
> and add_notes_attrs().
Looks good, queued.
Thanks!
Rusty.
next prev parent reply other threads:[~2009-12-21 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-19 14:43 [PATCH] modules: Skip empty sections when exporting section notes Ben Hutchings
2009-12-21 10:24 ` Rusty Russell [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-01-06 6:33 Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912212054.48469.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=ben@decadent.org.uk \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox