* [PATCH][GIT PULL] tracing: Fix setting tracer specific options
@ 2009-12-22 4:00 Steven Rostedt
2009-12-22 5:39 ` Li Zefan
2009-12-22 7:19 ` Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Steven Rostedt @ 2009-12-22 4:00 UTC (permalink / raw)
To: LKML; +Cc: Ingo Molnar, Peter Zijlstra, Li Zefan
Ingo,
Please pull the latest tip/tracing/urgent tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
tip/tracing/urgent
Steven Rostedt (1):
tracing: Fix setting tracer specific options
----
kernel/trace/trace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---------------------------
commit c757bea93bea4b77ebd181cc6dca60c15e3b1a2c
Author: Steven Rostedt <srostedt@redhat.com>
Date: Mon Dec 21 22:35:16 2009 -0500
tracing: Fix setting tracer specific options
The function __set_tracer_option() takes as its last parameter a
"neg" value. If set it should negate the value of the option.
The trace_options_write() passed the value written to the file
which is what the new value needs to be set as. But since this
is not the negative, it never sets the value.
Reported-by: Peter Zijlstra <peterz@infradead.org>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index ee61915..d0a4c12 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -3949,7 +3949,7 @@ trace_options_write(struct file *filp, const char __user *ubuf, size_t cnt,
if (!!(topt->flags->val & topt->opt->bit) != val) {
mutex_lock(&trace_types_lock);
ret = __set_tracer_option(current_trace, topt->flags,
- topt->opt, val);
+ topt->opt, !val);
mutex_unlock(&trace_types_lock);
if (ret)
return ret;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][GIT PULL] tracing: Fix setting tracer specific options
2009-12-22 4:00 [PATCH][GIT PULL] tracing: Fix setting tracer specific options Steven Rostedt
@ 2009-12-22 5:39 ` Li Zefan
2009-12-22 7:19 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Li Zefan @ 2009-12-22 5:39 UTC (permalink / raw)
To: rostedt; +Cc: LKML, Ingo Molnar, Peter Zijlstra
Steven Rostedt wrote:
> Ingo,
>
> Please pull the latest tip/tracing/urgent tree, which can be found at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
> tip/tracing/urgent
>
>
> Steven Rostedt (1):
> tracing: Fix setting tracer specific options
>
Oops, I tested global options only..
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][GIT PULL] tracing: Fix setting tracer specific options
2009-12-22 4:00 [PATCH][GIT PULL] tracing: Fix setting tracer specific options Steven Rostedt
2009-12-22 5:39 ` Li Zefan
@ 2009-12-22 7:19 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2009-12-22 7:19 UTC (permalink / raw)
To: Steven Rostedt; +Cc: LKML, Peter Zijlstra, Li Zefan
* Steven Rostedt <rostedt@goodmis.org> wrote:
> Ingo,
>
> Please pull the latest tip/tracing/urgent tree, which can be found at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
> tip/tracing/urgent
>
>
> Steven Rostedt (1):
> tracing: Fix setting tracer specific options
>
> ----
> kernel/trace/trace.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Pulled, thanks Steve!
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-22 7:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-22 4:00 [PATCH][GIT PULL] tracing: Fix setting tracer specific options Steven Rostedt
2009-12-22 5:39 ` Li Zefan
2009-12-22 7:19 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox