From: Al Viro <viro@ZenIV.linux.org.uk>
To: Liuwenyi <qingshenlwy@gmail.com>
Cc: chris.mason@oracle.com, joel.becker@oracle.com, cjb@laptop.org,
jmorris@namei.org, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, onlyflyer@gmail.com,
strongzgy@gmail.com
Subject: Re: [PATCHv2 02/12]posix_acl: Add the check items
Date: Tue, 22 Dec 2009 12:08:03 +0000 [thread overview]
Message-ID: <20091222120803.GR18217@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4B2F619A.8000407@gmail.com>
On Mon, Dec 21, 2009 at 07:52:58PM +0800, Liuwenyi wrote:
> @@ -102,12 +102,9 @@ static int btrfs_set_acl(struct btrfs_trans_handle
> *trans,
> char *value = NULL;
> mode_t mode;
>
> - if (acl) {
> - ret = posix_acl_valid(acl);
> - if (ret < 0)
> - return ret;
> - ret = 0;
> - }
> + ret = posix_acl_valid(acl);
> + if (ret < 0)
> + return ret;
... and now you can't remove acl from btrfs inode. At all.
NAK the entire series. You are changing existing user-visible behaviour
for all filesystems for no reason and at least in this case it's clearly
wrong change.
next prev parent reply other threads:[~2009-12-22 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 11:52 [PATCHv2 02/12]posix_acl: Add the check items Liuwenyi
2009-12-22 12:08 ` Al Viro [this message]
2009-12-22 14:31 ` liu weni
2009-12-22 14:48 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091222120803.GR18217@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=chris.mason@oracle.com \
--cc=cjb@laptop.org \
--cc=jmorris@namei.org \
--cc=joel.becker@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=onlyflyer@gmail.com \
--cc=qingshenlwy@gmail.com \
--cc=strongzgy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox