Re: mac80211 suspend corner case (was: Asus eeepc 1008HA suspend issue and mac80211 suspend corner) case

Johannes Berg
2009-12-23T19:01:59Z

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

On Wed, 2009-12-23 at 08:28 -0800, Luis R. Rodriguez wrote:

> > Well it seems to me that if the driver determines that the hardware
> is
> > unreachable or not responding, it would unregister it from mac80211,
> > which would clean up all user-visible state, obviously.
>
> The drivers would not know this until it fails on the first call
> from mac80211 which would be start().

Which is why this patch may be a good way to solve that particular
problem.

> > The patch above seems ok to me, but basically papers over the
> problem.
> > If the start there fails, the driver will have to unregister the hw
> > since any subsequent start will fail as well.
>
> How about just having mac80211 do that for drivers where the start()
> fails and we are resuming? I can give that a shot.

No way, the driver will invariably assume things are still going and
might later unregister etc. Too much magic.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]