From: Andrew Morton <akpm@linux-foundation.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: "Smith, GeoffX" <geoffx.smith@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Stone <michael@laptop.org>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] prctl: return MCE process flags through pointer
Date: Wed, 23 Dec 2009 02:18:07 -0800 [thread overview]
Message-ID: <20091223021807.abbd993e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20091223095223.GB20539@basil.fritz.box>
On Wed, 23 Dec 2009 10:52:23 +0100 Andi Kleen <andi@firstfloor.org> wrote:
> On Tue, Dec 22, 2009 at 05:34:24PM -0800, Andrew Morton wrote:
> > On Wed, 23 Dec 2009 02:14:51 +0100 Andi Kleen <andi@firstfloor.org> wrote:
> >
> > > "Smith, GeoffX" <geoffx.smith@intel.com> writes:
> > >
> > > > This patch fixes the semantics of prctl() option PR_MCE_KILL_GET
> > > > to pass the return value through *arg2.
> > > >
> > > > With this change, the option now follows the same conventions as the
> > > > other "get" options added since 2.6.0, and also brings it into
> > > > conformance with the advice in chapter 16 of Documentation/CodingStyle.
> > > >
> > > > This prctl() option was only added within the last month, so there are
> > > > not any production applications to break. This patch applies cleanly
> > > > to mainline and to 2.6.32.2 for backporting.
> > >
> > > It breaks the test suite, the man pages, qemu and one slide deck at least.
> > >
> >
> > Should've got it right the first time.
>
> To be honest it's not fully clear to me what is "wrong" with returning
> the return value with "return".
Just a convention thing.
> If there was a security bug or something maybe such a radical step
> as changing a published API would be justified, but for this I'm sceptical.
hm, OK, shrug.
Regarding "prctl: return timerslack through pointer": are there any
known users of PR_GET_TIMERSLACK yet?
Why are task_struct.timer_slack_ns and
task_struct.default_timer_slack_ns unsigned long, btw? AFACIT we could
make them unsigned ints.
next prev parent reply other threads:[~2009-12-23 10:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 0:33 [PATCH] prctl: return MCE process flags through pointer Smith, GeoffX
2009-12-23 1:14 ` Andi Kleen
2009-12-23 1:34 ` Andrew Morton
2009-12-23 9:52 ` Andi Kleen
2009-12-23 10:18 ` Andrew Morton [this message]
2009-12-23 17:56 ` Smith, GeoffX
2009-12-23 18:54 ` Andrew Morton
2009-12-23 20:24 ` Smith, GeoffX
2009-12-25 8:35 ` Arjan van de Ven
2009-12-23 19:31 ` Andi Kleen
2009-12-25 8:30 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091223021807.abbd993e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=geoffx.smith@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@laptop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox