Re: workqueue thing

Peter Zijlstra
2009-12-22T11:05:09Z

On Tue, 2009-12-22 at 08:50 +0900, Tejun Heo wrote:
> > But as it stands I don't think its wise to replace the current workqueue
> > implementation with this, esp since there are known heavy CPU users
> > using it, nor have you addressed the queueing issue (or is that the
> > restoration of the single-queue workqueue?)
>
> The queueing one is addressed and which CPU-heavy users are you
> talking about? Workqueues have always been CPU-affine. Not much
> changes for its users by cmwq.

crypto for one (no clue what other bits we have atm, there might be some
async raid-n helper bits too, or whatever).

And yes that does change, the current design ensures we don't run more
than one crypto job per cpu, whereas with your stuff that can be
arbitrary many per cpu (up to some artificial limit of 127 or so).