public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [patch 6/7] [patch] rtl8192su, rtl8192u: use min_t() in store_debug_level()
Date: Wed, 23 Dec 2009 19:54:54 +1100	[thread overview]
Message-ID: <20091223085553.389673883@vergenet.net> (raw)
In-Reply-To: 20091223085448.619253793@vergenet.net

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: rtl8192u-store_debug_level-min_t.patch --]
[-- Type: text/plain, Size: 2143 bytes --]

sizeof() returns a size_t but the other types involved
are unsigned long, so using min() results in a warning.

As sizeof() is called on an 11 character buffer defined
immediately above unsigned long is obviously wide enough
for the result.

Signed-off-by: Simon Horman <horms@verge.net.au>

--- 

Compile tested only.

$ gcc --version
gcc (Debian 4.4.2-6) 4.4.2
Copyright (C) 2009 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ make CONFIG_DEBUG_SECTION_MISMATCH=y
...
drivers/staging/rtl8192su/ieee80211/ieee80211_module.c: In function ‘store_debug_level’:
drivers/staging/rtl8192su/ieee80211/ieee80211_module.c:265: warning: comparison of distinct pointer types lacks a cast
...

Index: gregkh-2.6/drivers/staging/rtl8192su/ieee80211/ieee80211_module.c
===================================================================
--- gregkh-2.6.orig/drivers/staging/rtl8192su/ieee80211/ieee80211_module.c	2009-12-23 19:24:36.000000000 +1100
+++ gregkh-2.6/drivers/staging/rtl8192su/ieee80211/ieee80211_module.c	2009-12-23 19:24:38.000000000 +1100
@@ -262,7 +262,7 @@ static int store_debug_level(struct file
 			     unsigned long count, void *data)
 {
 	char buf[] = "0x00000000";
-	unsigned long len = min(sizeof(buf) - 1, count);
+	unsigned long len = min_t(unsigned long, sizeof(buf) - 1, count);
 	char *p = (char *)buf;
 	unsigned long val;
 
Index: gregkh-2.6/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
===================================================================
--- gregkh-2.6.orig/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c	2009-12-23 19:24:47.000000000 +1100
+++ gregkh-2.6/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c	2009-12-23 19:24:50.000000000 +1100
@@ -260,7 +260,7 @@ static int store_debug_level(struct file
 			     unsigned long count, void *data)
 {
 	char buf[] = "0x00000000";
-	unsigned long len = min(sizeof(buf) - 1, count);
+	unsigned long len = min_t(unsigned long, sizeof(buf) - 1, count);
 	char *p = (char *)buf;
 	unsigned long val;
 


  parent reply	other threads:[~2009-12-23  8:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-23  8:54 [patch 0/7] minor cleanups for various staging drivers Simon Horman
2009-12-23  8:54 ` [patch 1/7] [patch] DT3155: Use pci_get_device Simon Horman
2009-12-23 16:19   ` Greg KH
2009-12-23 22:02     ` Simon Horman
2009-12-23 23:37       ` Greg KH
2009-12-24  2:11         ` Simon Horman
2009-12-23  8:54 ` [patch 2/7] [patch] rt2870: rtusb_probe() should be in section __devinit Simon Horman
2009-12-23  8:54 ` [patch 3/7] [patch] rt2870: Remove unnecessary forward declarations Simon Horman
2009-12-23  8:54 ` [patch 4/7] [patch] rtl8192e: print the elements of tx_pn and rx_pn not the arrays themselves Simon Horman
2009-12-23  8:54 ` [patch 5/7] [patch] rtl8192e: remove some functions from the __exit section Simon Horman
2009-12-23  8:54 ` Simon Horman [this message]
     [not found] ` <20091223085553.648368336@vergenet.net>
2009-12-23 10:39   ` [patch 7/7] [patch] rtl8192u: Clarify logic in‘ieee80211_wx_get_encode_ext_rsl() Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091223085553.389673883@vergenet.net \
    --to=horms@verge.net.au \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox