public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Smith, GeoffX" <geoffx.smith@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Michael Stone <michael@laptop.org>,
	Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] prctl: return MCE process flags through pointer
Date: Wed, 23 Dec 2009 10:54:50 -0800	[thread overview]
Message-ID: <20091223105450.8f15db9f.akpm@linux-foundation.org> (raw)
In-Reply-To: <354B2877CF17F44BB3FA44EB4DB0E5470C91CE18A8@orsmsx510.amr.corp.intel.com>

On Wed, 23 Dec 2009 09:56:04 -0800 "Smith, GeoffX" <geoffx.smith@intel.com> wrote:

> >Why are task_struct.timer_slack_ns and
> >task_struct.default_timer_slack_ns unsigned long, btw?  AFACIT we could
> >make them unsigned ints.
> 
> Timer slack is not a Boolean or enum, and we want the greatest range possible.  (Actually, I'd like to talk Arjan into using the same time structure as select(), but that's another discussion.) Internally hrtimer uses unsigned long.  I know long and unsigned long are the same on some architectures, but let's not introduce an unnatural restriction -- recall that arg2 is unsigned long.

Using unsigned ints will reduce the size of the task_struct.

Is there any conceivable case for a timer_slack which exceeds four
seconds?  If so, what is it, and if so, why this:

#define MAX_SLACK       (100 * NSEC_PER_MSEC)

?

  reply	other threads:[~2009-12-23 18:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-23  0:33 [PATCH] prctl: return MCE process flags through pointer Smith, GeoffX
2009-12-23  1:14 ` Andi Kleen
2009-12-23  1:34   ` Andrew Morton
2009-12-23  9:52     ` Andi Kleen
2009-12-23 10:18       ` Andrew Morton
2009-12-23 17:56         ` Smith, GeoffX
2009-12-23 18:54           ` Andrew Morton [this message]
2009-12-23 20:24             ` Smith, GeoffX
2009-12-25  8:35             ` Arjan van de Ven
2009-12-23 19:31           ` Andi Kleen
2009-12-25  8:30         ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091223105450.8f15db9f.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=arjan@infradead.org \
    --cc=geoffx.smith@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@laptop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox