From: tytso@mit.edu
To: Julia Lawall <julia@diku.dk>
Cc: Andreas Dilger <adilger@sun.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] fs/ext4: Eliminate double free
Date: Wed, 23 Dec 2009 07:53:34 -0500 [thread overview]
Message-ID: <20091223125334.GE21594@thunk.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0912201806530.26912@ask.diku.dk>
On Sun, Dec 20, 2009 at 06:07:10PM +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> b_entry_name and buffer are initially NULL, are initialized within a loop
> to the result of calling kmalloc, and are freed at the bottom of this loop.
> The loop contains gotos to cleanup, which also frees b_entry_name and
> buffer. Some of these gotos are before the reinitializations of
> b_entry_name and buffer. To maintain the invariant that b_entry_name and
> buffer are NULL at the top of the loop, and thus acceptable arguments to
> kfree, these variables are now set to NULL after the kfrees.
>
> This seems to be the simplest solution. A more complicated solution
> would be to introduce more labels in the error handling code at the end of
> the function.
Thanks, added to the ext4 patch queue.
- Ted
prev parent reply other threads:[~2009-12-23 12:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 17:07 [PATCH 2/2] fs/ext4: Eliminate double free Julia Lawall
2009-12-23 12:53 ` tytso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091223125334.GE21594@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox