From: Dan Carpenter <error27@gmail.com>
To: Matt Mackall <mpm@selenic.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>, linux-kernel@vger.kernel.org
Subject: double unlock in rng_dev_read()
Date: Wed, 23 Dec 2009 15:15:52 +0200 [thread overview]
Message-ID: <20091223131552.GA17923@bicker> (raw)
It seems like we unlock rng_mutex twice (2.6.33-rc1).
drivers/char/hw_random/core.c
151 mutex_unlock(&rng_mutex);
152
153 if (need_resched())
154 schedule_timeout_interruptible(1);
155
156 if (signal_pending(current)) {
157 err = -ERESTARTSYS;
158 goto out;
159 }
160 }
161 out_unlock:
162 mutex_unlock(&rng_mutex);
regards,
dan carpenter
next reply other threads:[~2009-12-23 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 13:15 Dan Carpenter [this message]
2009-12-23 14:36 ` double unlock in rng_dev_read() Herbert Xu
2009-12-23 14:53 ` Dan Carpenter
2009-12-23 15:23 ` Herbert Xu
2009-12-24 10:51 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091223131552.GA17923@bicker \
--to=error27@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox