From: Andi Kleen <andi@firstfloor.org>
To: "Smith, GeoffX" <geoffx.smith@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Stone <michael@laptop.org>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] prctl: return MCE process flags through pointer
Date: Wed, 23 Dec 2009 20:31:12 +0100 [thread overview]
Message-ID: <20091223193112.GN20539@basil.fritz.box> (raw)
In-Reply-To: <354B2877CF17F44BB3FA44EB4DB0E5470C91CE18A8@orsmsx510.amr.corp.intel.com>
> Sorry, I wasn't aware of any published API, PR_MCE_KILL and KILL_GET just got accepted into mainline.
An API is published as soon as the kernel including it is released.
>
> I just noticed that these new options didn't follow the conventions of most prctl() options. There is only one option newer than 2.3.48 that uses return-as-function-result, and that one is essentially a no-op.
We could have fixed it if you had mentioned that during code review before 2.6.32, but
now it's too late (at least unless it would have been fundamentally broken or something like
that, but I don't think that's the case)
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-12-23 19:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 0:33 [PATCH] prctl: return MCE process flags through pointer Smith, GeoffX
2009-12-23 1:14 ` Andi Kleen
2009-12-23 1:34 ` Andrew Morton
2009-12-23 9:52 ` Andi Kleen
2009-12-23 10:18 ` Andrew Morton
2009-12-23 17:56 ` Smith, GeoffX
2009-12-23 18:54 ` Andrew Morton
2009-12-23 20:24 ` Smith, GeoffX
2009-12-25 8:35 ` Arjan van de Ven
2009-12-23 19:31 ` Andi Kleen [this message]
2009-12-25 8:30 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091223193112.GN20539@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=geoffx.smith@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@laptop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox