From: Julien Cristau <jcristau@debian.org>
To: Darren Jenkins <darrenrjenkins@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel mailing list <dri-devel@lists.sourceforge.net>,
Kernel Janitors <kernel-janitors@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: drivers/gpu/drm/radeon: move a dereference below a NULL test
Date: Fri, 25 Dec 2009 11:13:18 +0100 [thread overview]
Message-ID: <20091225101318.GQ3003@radis.liafa.jussieu.fr> (raw)
In-Reply-To: <1261658670.3546.7.camel@ICE-BOX>
On Thu, Dec 24, 2009 at 23:44:30 +1100, Darren Jenkins wrote:
> If a NULL value is possible, the dereference should only occur after the
> NULL test.
>
> Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
> diff --git a/drivers/gpu/drm/radeon/radeon_irq.c
> b/drivers/gpu/drm/radeon/radeon_irq.c
> index b79ecc4..2f349a3 100644
> --- a/drivers/gpu/drm/radeon/radeon_irq.c
> +++ b/drivers/gpu/drm/radeon/radeon_irq.c
> @@ -289,16 +289,16 @@ int radeon_irq_emit(struct drm_device *dev, void
> *data, struct drm_file *file_pr
Looks like your patches are whitespace-damaged. You'll need to fix your
MUA...
Cheers,
Julien
prev parent reply other threads:[~2009-12-25 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-24 12:44 drivers/gpu/drm/radeon: move a dereference below a NULL test Darren Jenkins
2009-12-25 10:13 ` Julien Cristau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091225101318.GQ3003@radis.liafa.jussieu.fr \
--to=jcristau@debian.org \
--cc=airlied@linux.ie \
--cc=darrenrjenkins@gmail.com \
--cc=dri-devel@lists.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox