Re: [PATCH] x86, perfctr: remove unused func avail_to_resrv_perfctr_nmi()

Ingo Molnar
2009-12-28T10:00:51Z

* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> > Not that i know of.
>
> ok, then we could apply this patch I think, at least for a while.

yeah, i have applied it.

> > In fact we should transform/migrate the NMI watchdog driver by making it
> > based on a kernel-internal created perf event. (which is what the NMI
> > watchdog really is: a periodic NMI event occuring once per second and
> > running a callback function.)
>
> Yes, this would be great. I'll try to find out some time for this task,
> though no promises :) If someone get it done earlier I would really
> appreciate.

Feel free to do it. We could do it gradual. Maybe we could also then gradually
remove perfctr code for CPU variants that already have perf events support.

Plus later on we could carefully identify bits of APIC support code in
perfctr.c and turn those into minimal perf events PMU drivers.

Ingo