From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jan Beulich <JBeulich@novell.com>,
tglx@linutronix.de, hpa@zytor.com,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Nick Piggin <npiggin@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: slightly shorten __ticket_spin_trylock() (v3)
Date: Mon, 28 Dec 2009 09:48:21 +0100 [thread overview]
Message-ID: <20091228084821.GA24690@elte.hu> (raw)
In-Reply-To: <alpine.LFD.2.00.0912180822380.3712@localhost.localdomain>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Fri, 18 Dec 2009, Jan Beulich wrote:
> >
> > -static __always_inline int __ticket_spin_trylock(arch_spinlock_t *lock)
> > +static __always_inline u8 __ticket_spin_trylock(arch_spinlock_t *lock)
>
[...]
>
> I dunno. I still don't get the feeling that any of this actually
> _matters_.
Jan, to apply this patch it would be nice to see a before/after
comparison/analysis of a defconfig vmlinux image with a reasonably uptodate
GCC - to see how much this all matters in practice.
Ingo
prev parent reply other threads:[~2009-12-28 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 16:01 [PATCH] x86: slightly shorten __ticket_spin_trylock() (v3) Jan Beulich
2009-12-18 16:36 ` Linus Torvalds
2009-12-28 8:48 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091228084821.GA24690@elte.hu \
--to=mingo@elte.hu \
--cc=JBeulich@novell.com \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox