From: Pavel Machek <pavel@ucw.cz>
To: Brian Swetland <swetland@google.com>
Cc: Arve Hj?nnev?g <arve@android.com>,
Daniel Walker <dwalker@codeaurora.org>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Iliyan Malchev <malchev@google.com>,
linux-kernel@codeaurora.org, Greg KH <greg@kroah.com>
Subject: Re: tree with htc dream support
Date: Mon, 28 Dec 2009 21:52:57 +0100 [thread overview]
Message-ID: <20091228205257.GA1862@ucw.cz> (raw)
In-Reply-To: <20091228204848.GB1637@ucw.cz>
On Mon 2009-12-28 21:48:48, Pavel Machek wrote:
> Hi!
>
> > >> > Switch smd code to the version in staging. Something to apply to
> > >> > dream/ tree I'd say... and yes, it still works.
> > >>
> > >> I think we might want to consider leaving at least the core smd code
> > >> under mach-msm.
> > >
> > > In the long run, I agree.
> > >
> > > In the short run... the code is staging quality, so it should be in
> > > staging... and you'll not have to mainain so huge diff. (-20 kLoc).
> >
> > The core smd stuff is really not that large. The central smd.[ch] are
> > about 1300 lines, and proc_comm.[ch] are about 400 lines. Is it
> > possible to get some review/feedback as to what's "staging quality"
> > about this code so we can clean it up? I'd rather just fix the
> > issues
>
> Just submit it to Daniel W., ccing rmk and l-a-k, and I'm sure you'll
> get feedback.
>
> For a start, checkpatch has some mild complains.
BTW if would be cool to fix style in the staging/, then do git mv, so
that cleanups are clearly separated/changelogged in kernel proper...
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-12-28 20:53 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-05 22:11 tree with htc dream support Pavel Machek
2009-12-05 23:12 ` Daniel Walker
2009-12-06 7:41 ` Pavel Machek
2009-12-06 13:51 ` Daniel Walker
2009-12-08 8:53 ` Pavel Machek
[not found] ` <a55d774e0912051638u7858878cg7cf62905c3c005c1@mail.gmail.com>
2009-12-06 7:43 ` Pavel Machek
2009-12-06 13:55 ` Daniel Walker
2009-12-12 5:42 ` Arve Hjønnevåg
2009-12-12 11:17 ` Pavel Machek
2009-12-12 11:25 ` Pavel Machek
2009-12-12 11:51 ` Arve Hjønnevåg
2009-12-12 12:11 ` Arve Hjønnevåg
2009-12-12 17:53 ` Pavel Machek
2009-12-12 22:41 ` Arve Hjønnevåg
2009-12-15 6:30 ` Arve Hjønnevåg
2009-12-12 14:18 ` Daniel Walker
2009-12-12 22:34 ` Arve Hjønnevåg
2009-12-13 21:25 ` Pavel Machek
2009-12-15 6:34 ` Arve Hjønnevåg
2009-12-15 22:20 ` Pavel Machek
2009-12-27 9:35 ` Pavel Machek
2009-12-27 20:15 ` Pavel Machek
2009-12-27 20:20 ` Brian Swetland
2009-12-27 20:37 ` Pavel Machek
2009-12-27 21:13 ` Pavel Machek
2009-12-27 21:53 ` Pavel Machek
2009-12-28 0:46 ` Brian Swetland
2009-12-27 10:18 ` Pavel Machek
2009-12-28 20:24 ` Brian Swetland
2009-12-28 20:48 ` Pavel Machek
2009-12-28 20:52 ` Pavel Machek [this message]
2009-12-28 21:08 ` Brian Swetland
2010-01-01 14:54 ` Pavel Machek
2009-12-29 1:25 ` Daniel Walker
2010-01-01 15:18 ` Pavel Machek
2010-01-01 16:08 ` Daniel Walker
2010-01-02 10:55 ` Pavel Machek
2010-01-05 21:31 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091228205257.GA1862@ucw.cz \
--to=pavel@ucw.cz \
--cc=arve@android.com \
--cc=dwalker@codeaurora.org \
--cc=greg@kroah.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malchev@google.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox