From: Frederic Weisbecker <fweisbec@gmail.com>
To: "K.Prasad" <prasad@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Alan Stern <stern@rowland.harvard.edu>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [RFC Patch 2/2][Bugfix][x86][hw-breakpoint] Fix return-code to notifier chain in hw_breakpoint_handler
Date: Thu, 31 Dec 2009 01:44:47 +0100 [thread overview]
Message-ID: <20091231004446.GD23808@nowhere> (raw)
In-Reply-To: <20091226182833.GC9494@in.ibm.com>
On Sat, Dec 26, 2009 at 11:58:33PM +0530, K.Prasad wrote:
> + /*
> + * Further processing in do_debug() is needed for a) user-space
> + * breakpoints (to generate signals) and b) when the system has
> + * taken exception due to multiple causes
> + */
> + if (bp->attr.bp_addr < TASK_SIZE)
> + rc = NOTIFY_DONE;
BTW, I'm not sure this is the right way to check if we want to send
a signal or not. Although it's not yet supported, we'll probably
bring the support for userspace breakpoints by perf.
May be we should put a "ptrace" flag in struct hw_perf_event instead.
next prev parent reply other threads:[~2009-12-31 0:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091226175533.149765731@linux.vnet.ibm.com>
2009-12-26 18:27 ` [RFC Patch 1/2][Bugfix][x86][hw-breakpoint] Clear reserved bits of DR6 in do_debug() K.Prasad
2009-12-30 23:45 ` Frederic Weisbecker
2009-12-31 18:49 ` K.Prasad
2010-01-10 3:22 ` Frederic Weisbecker
2009-12-26 18:28 ` [RFC Patch 2/2][Bugfix][x86][hw-breakpoint] Fix return-code to notifier chain in hw_breakpoint_handler K.Prasad
2009-12-31 0:33 ` Frederic Weisbecker
2009-12-31 0:38 ` Frederic Weisbecker
2009-12-31 19:02 ` K.Prasad
2010-01-10 3:18 ` Frederic Weisbecker
2010-01-11 19:15 ` Jan Kiszka
2010-01-16 19:41 ` K.Prasad
2010-01-20 6:01 ` K.Prasad
2010-01-22 9:14 ` Jan Kiszka
2010-01-22 9:21 ` K.Prasad
2010-01-25 22:21 ` Frederic Weisbecker
2010-01-27 10:29 ` K.Prasad
2009-12-31 0:44 ` Frederic Weisbecker [this message]
2010-01-25 22:11 ` Frederic Weisbecker
2010-01-27 10:28 ` K.Prasad
2010-01-27 16:11 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091231004446.GD23808@nowhere \
--to=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=prasad@linux.vnet.ibm.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox