* [PATCH] fs/compat_ioctl.c: Add KD[GS]KBDIACRUC to the compatible list @ 2010-01-01 13:56 Michael Schutte 2010-01-01 17:20 ` Arnd Bergmann 0 siblings, 1 reply; 3+ messages in thread From: Michael Schutte @ 2010-01-01 13:56 UTC (permalink / raw) To: linux-kernel; +Cc: Samuel Thibault Allow handling of Unicode compose sequences by 32-bit apps on a 64-bit system. The issue has been reported in <http://bugs.debian.org/540534> and <http://lists.altlinux.org/pipermail/kbd/2009-December/000235.html>. A formal check of the two affected ioctls in drivers/char/vt_ioctl.c (introduced in 04c71976) and a test using x86 kbd 1.15.1 on a so patched x86_64 kernel both confirm that KD[GS]KBDIACRUC are ioctl32() compatible. Signed-off-by: Michael Schutte <michi@uiae.at> --- fs/compat_ioctl.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c index 332dd00..07096e9 100644 --- a/fs/compat_ioctl.c +++ b/fs/compat_ioctl.c @@ -991,6 +991,8 @@ COMPATIBLE_IOCTL(KDGKBSENT) COMPATIBLE_IOCTL(KDSKBSENT) COMPATIBLE_IOCTL(KDGKBDIACR) COMPATIBLE_IOCTL(KDSKBDIACR) +COMPATIBLE_IOCTL(KDGKBDIACRUC) +COMPATIBLE_IOCTL(KDSKBDIACRUC) COMPATIBLE_IOCTL(KDKBDREP) COMPATIBLE_IOCTL(KDGKBLED) COMPATIBLE_IOCTL(KDGETLED) -- 1.6.5 -- Michael Schutte <michi@uiae.at> ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/compat_ioctl.c: Add KD[GS]KBDIACRUC to the compatible list 2010-01-01 13:56 [PATCH] fs/compat_ioctl.c: Add KD[GS]KBDIACRUC to the compatible list Michael Schutte @ 2010-01-01 17:20 ` Arnd Bergmann 2010-01-01 17:59 ` Michael Schutte 0 siblings, 1 reply; 3+ messages in thread From: Arnd Bergmann @ 2010-01-01 17:20 UTC (permalink / raw) To: Michael Schutte; +Cc: linux-kernel, Samuel Thibault On Friday 01 January 2010, Michael Schutte wrote: > Allow handling of Unicode compose sequences by 32-bit apps on a 64-bit > system. The issue has been reported in <http://bugs.debian.org/540534> > and <http://lists.altlinux.org/pipermail/kbd/2009-December/000235.html>. > > A formal check of the two affected ioctls in drivers/char/vt_ioctl.c > (introduced in 04c71976) and a test using x86 kbd 1.15.1 on a so patched > x86_64 kernel both confirm that KD[GS]KBDIACRUC are ioctl32() > compatible. > > Signed-off-by: Michael Schutte <michi@uiae.at> Since 2.6.32, we handle all VT specific ioctls in the vt_compat_ioctl() function, which should fix this one implicitly. Please try to reproduce with a recent kernel. Arnd ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/compat_ioctl.c: Add KD[GS]KBDIACRUC to the compatible list 2010-01-01 17:20 ` Arnd Bergmann @ 2010-01-01 17:59 ` Michael Schutte 0 siblings, 0 replies; 3+ messages in thread From: Michael Schutte @ 2010-01-01 17:59 UTC (permalink / raw) To: linux-kernel; +Cc: Samuel Thibault On Fri, Jan 01, 2010 at 06:20:50PM +0100, Arnd Bergmann wrote: > On Friday 01 January 2010, Michael Schutte wrote: > > Allow handling of Unicode compose sequences by 32-bit apps on a 64-bit > > system. The issue has been reported in <http://bugs.debian.org/540534> > > and <http://lists.altlinux.org/pipermail/kbd/2009-December/000235.html>. > > […] > > Since 2.6.32, we handle all VT specific ioctls in the vt_compat_ioctl() > function, which should fix this one implicitly. Please try to reproduce > with a recent kernel. Works indeed. Thank you for the pointer and sorry for the noise. Cheers, -- Michael Schutte <michi@uiae.at> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-01 17:59 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-01-01 13:56 [PATCH] fs/compat_ioctl.c: Add KD[GS]KBDIACRUC to the compatible list Michael Schutte 2010-01-01 17:20 ` Arnd Bergmann 2010-01-01 17:59 ` Michael Schutte
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox