Re: [patch staging] BCM70010 (crystalhd) Linux Driver

[Greg KH <greg@kroah.com>]

On Sat, Jan 02, 2010 at 10:17:04PM +0400, Manu Abraham wrote:
> On Sat, Jan 2, 2010 at 8:34 PM, Greg KH <greg@kroah.com> wrote:
> > On Sat, Jan 02, 2010 at 08:05:38PM +0400, Manu Abraham wrote:
> >> Hi Greg,
> >>
> >> > I'm glad to do so if someone wants to help work on it there and shephard
> >> > it into the main kernel tree.
> >>
> >> Please find the initial round of cleaned up patches for staging,
> >> applied against linux-next.
> >
> > Did you really author this driver?  If so, that's fine, just checking.
> > If not, please put the correct authorship "From:" in the patch.
> 
> I am not the author of the driver. I just picked it up and cleaned it
> up for Coding style changes for it to be included.

Can we try to figure out who the author is and please credit them?

> > Also, please break up patches to be sent one-per-email so they can be
> > properly applied, and also only have them do one thing (your 4th patch
> > fixed up coding style issues and added the driver to the build.)
> 
> Okay, I will resend them.
> 
> > Also, can you add a TODO file to the driver directory stating what is
> > needed to be done, and who to contact about it?
> 
> I will test the device over the coming week and add in a TODO after that.

I need a TODO before I can accept the patches, sorry.

thanks,

greg k-h