* BCM70010 (crystalhd) Linux Driver @ 2009-12-30 20:06 Peter Paul 2009-12-31 13:18 ` Andrey Panin 0 siblings, 1 reply; 11+ messages in thread From: Peter Paul @ 2009-12-30 20:06 UTC (permalink / raw) To: linux-kernel Broadcom has just released a linux driver for their BCM70012 and BCM70015 Crystal HD High Definition video decoders under the GPLv2 licence. [1] Maybe you want to have a look at them. [1] http://www.broadcom.com/support/crystal_hd/ ___________________________________________________________ Preisknaller: WEB.DE DSL Flatrate für nur 16,99 Euro/mtl.! http://produkte.web.de/go/02/ ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: BCM70010 (crystalhd) Linux Driver 2009-12-30 20:06 BCM70010 (crystalhd) Linux Driver Peter Paul @ 2009-12-31 13:18 ` Andrey Panin 2010-01-01 0:19 ` Greg KH 0 siblings, 1 reply; 11+ messages in thread From: Andrey Panin @ 2009-12-31 13:18 UTC (permalink / raw) To: Peter Paul; +Cc: linux-kernel On 364, 12 30, 2009 at 09:06:15PM +0100, Peter Paul wrote: > Broadcom has just released a linux driver for their BCM70012 and BCM70015 Crystal HD High Definition video decoders under the GPLv2 licence. [1] > Maybe you want to have a look at them. > > [1] http://www.broadcom.com/support/crystal_hd/ >From quick inspection kernel part looks much better than most vendor-provided drivers. It needs some cleanups and bugfixes, for example error handling in device probe function doesn't look right to me, driver can't handle more than one device as far as I can see (I don't know is it really needed though), etc. But anyway this driver definitely deserves putting into staging. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: BCM70010 (crystalhd) Linux Driver 2009-12-31 13:18 ` Andrey Panin @ 2010-01-01 0:19 ` Greg KH [not found] ` <1a297b361001020805y6b00af83g81cf8492aa73bc3b@mail.gmail.com> 0 siblings, 1 reply; 11+ messages in thread From: Greg KH @ 2010-01-01 0:19 UTC (permalink / raw) To: Peter Paul, linux-kernel On Thu, Dec 31, 2009 at 04:18:52PM +0300, Andrey Panin wrote: > On 364, 12 30, 2009 at 09:06:15PM +0100, Peter Paul wrote: > > Broadcom has just released a linux driver for their BCM70012 and BCM70015 Crystal HD High Definition video decoders under the GPLv2 licence. [1] > > Maybe you want to have a look at them. > > > > [1] http://www.broadcom.com/support/crystal_hd/ > > >From quick inspection kernel part looks much better than most vendor-provided > drivers. It needs some cleanups and bugfixes, for example error handling in > device probe function doesn't look right to me, driver can't handle more than > one device as far as I can see (I don't know is it really needed though), etc. > But anyway this driver definitely deserves putting into staging. I'm glad to do so if someone wants to help work on it there and shephard it into the main kernel tree. thanks, greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <1a297b361001020805y6b00af83g81cf8492aa73bc3b@mail.gmail.com>]
* Re: [patch staging] BCM70010 (crystalhd) Linux Driver [not found] ` <1a297b361001020805y6b00af83g81cf8492aa73bc3b@mail.gmail.com> @ 2010-01-02 16:34 ` Greg KH 2010-01-02 18:17 ` Manu Abraham 0 siblings, 1 reply; 11+ messages in thread From: Greg KH @ 2010-01-02 16:34 UTC (permalink / raw) To: Manu Abraham; +Cc: Peter Paul, linux-kernel On Sat, Jan 02, 2010 at 08:05:38PM +0400, Manu Abraham wrote: > Hi Greg, > > > I'm glad to do so if someone wants to help work on it there and shephard > > it into the main kernel tree. > > Please find the initial round of cleaned up patches for staging, > applied against linux-next. Did you really author this driver? If so, that's fine, just checking. If not, please put the correct authorship "From:" in the patch. Also, please break up patches to be sent one-per-email so they can be properly applied, and also only have them do one thing (your 4th patch fixed up coding style issues and added the driver to the build.) Also, can you add a TODO file to the driver directory stating what is needed to be done, and who to contact about it? thanks, greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch staging] BCM70010 (crystalhd) Linux Driver 2010-01-02 16:34 ` [patch staging] " Greg KH @ 2010-01-02 18:17 ` Manu Abraham 2010-01-02 19:21 ` Greg KH 2010-01-02 22:03 ` Jon Smirl 0 siblings, 2 replies; 11+ messages in thread From: Manu Abraham @ 2010-01-02 18:17 UTC (permalink / raw) To: Greg KH; +Cc: Peter Paul, linux-kernel Hi Greg, On Sat, Jan 2, 2010 at 8:34 PM, Greg KH <greg@kroah.com> wrote: > On Sat, Jan 02, 2010 at 08:05:38PM +0400, Manu Abraham wrote: >> Hi Greg, >> >> > I'm glad to do so if someone wants to help work on it there and shephard >> > it into the main kernel tree. >> >> Please find the initial round of cleaned up patches for staging, >> applied against linux-next. > > Did you really author this driver? If so, that's fine, just checking. > If not, please put the correct authorship "From:" in the patch. I am not the author of the driver. I just picked it up and cleaned it up for Coding style changes for it to be included. > Also, please break up patches to be sent one-per-email so they can be > properly applied, and also only have them do one thing (your 4th patch > fixed up coding style issues and added the driver to the build.) Okay, I will resend them. > Also, can you add a TODO file to the driver directory stating what is > needed to be done, and who to contact about it? I will test the device over the coming week and add in a TODO after that. Thanks, Manu ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch staging] BCM70010 (crystalhd) Linux Driver 2010-01-02 18:17 ` Manu Abraham @ 2010-01-02 19:21 ` Greg KH 2010-01-02 20:08 ` Manu Abraham 2010-01-02 22:03 ` Jon Smirl 1 sibling, 1 reply; 11+ messages in thread From: Greg KH @ 2010-01-02 19:21 UTC (permalink / raw) To: Manu Abraham; +Cc: Peter Paul, linux-kernel On Sat, Jan 02, 2010 at 10:17:04PM +0400, Manu Abraham wrote: > On Sat, Jan 2, 2010 at 8:34 PM, Greg KH <greg@kroah.com> wrote: > > On Sat, Jan 02, 2010 at 08:05:38PM +0400, Manu Abraham wrote: > >> Hi Greg, > >> > >> > I'm glad to do so if someone wants to help work on it there and shephard > >> > it into the main kernel tree. > >> > >> Please find the initial round of cleaned up patches for staging, > >> applied against linux-next. > > > > Did you really author this driver? If so, that's fine, just checking. > > If not, please put the correct authorship "From:" in the patch. > > I am not the author of the driver. I just picked it up and cleaned it > up for Coding style changes for it to be included. Can we try to figure out who the author is and please credit them? > > Also, please break up patches to be sent one-per-email so they can be > > properly applied, and also only have them do one thing (your 4th patch > > fixed up coding style issues and added the driver to the build.) > > Okay, I will resend them. > > > Also, can you add a TODO file to the driver directory stating what is > > needed to be done, and who to contact about it? > > I will test the device over the coming week and add in a TODO after that. I need a TODO before I can accept the patches, sorry. thanks, greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch staging] BCM70010 (crystalhd) Linux Driver 2010-01-02 19:21 ` Greg KH @ 2010-01-02 20:08 ` Manu Abraham 0 siblings, 0 replies; 11+ messages in thread From: Manu Abraham @ 2010-01-02 20:08 UTC (permalink / raw) To: Greg KH; +Cc: Peter Paul, linux-kernel On Sat, Jan 2, 2010 at 11:21 PM, Greg KH <greg@kroah.com> wrote: > On Sat, Jan 02, 2010 at 10:17:04PM +0400, Manu Abraham wrote: >> On Sat, Jan 2, 2010 at 8:34 PM, Greg KH <greg@kroah.com> wrote: >> > On Sat, Jan 02, 2010 at 08:05:38PM +0400, Manu Abraham wrote: >> >> Hi Greg, >> >> >> >> > I'm glad to do so if someone wants to help work on it there and shephard >> >> > it into the main kernel tree. >> >> >> >> Please find the initial round of cleaned up patches for staging, >> >> applied against linux-next. >> > >> > Did you really author this driver? If so, that's fine, just checking. >> > If not, please put the correct authorship "From:" in the patch. >> >> I am not the author of the driver. I just picked it up and cleaned it >> up for Coding style changes for it to be included. > > Can we try to figure out who the author is and please credit them? Module author has 2 people on it, added them, hope it works. >> > Also, please break up patches to be sent one-per-email so they can be >> > properly applied, and also only have them do one thing (your 4th patch >> > fixed up coding style issues and added the driver to the build.) >> >> Okay, I will resend them. >> >> > Also, can you add a TODO file to the driver directory stating what is >> > needed to be done, and who to contact about it? >> >> I will test the device over the coming week and add in a TODO after that. > > I need a TODO before I can accept the patches, sorry. Ok will add in an initial TODO what i can see atm. Regards, Manu ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch staging] BCM70010 (crystalhd) Linux Driver 2010-01-02 18:17 ` Manu Abraham 2010-01-02 19:21 ` Greg KH @ 2010-01-02 22:03 ` Jon Smirl 2010-01-02 23:14 ` Manu Abraham 2010-01-03 4:51 ` Jarod Wilson 1 sibling, 2 replies; 11+ messages in thread From: Jon Smirl @ 2010-01-02 22:03 UTC (permalink / raw) To: Manu Abraham; +Cc: Greg KH, Peter Paul, linux-kernel On Sat, Jan 2, 2010 at 1:17 PM, Manu Abraham <abraham.manu@gmail.com> wrote: > Hi Greg, > > On Sat, Jan 2, 2010 at 8:34 PM, Greg KH <greg@kroah.com> wrote: >> On Sat, Jan 02, 2010 at 08:05:38PM +0400, Manu Abraham wrote: >>> Hi Greg, >>> >>> > I'm glad to do so if someone wants to help work on it there and shephard >>> > it into the main kernel tree. >>> >>> Please find the initial round of cleaned up patches for staging, >>> applied against linux-next. >> >> Did you really author this driver? If so, that's fine, just checking. >> If not, please put the correct authorship "From:" in the patch. > > I am not the author of the driver. I just picked it up and cleaned it > up for Coding style changes for it to be included. I'm not against this submission, but would it be better to wait until Monday when the Broadcom authors are back as see if they want to submit their own driver? That way changes would end up back in their internal VCS. I'd like to see a real datasheet for this chip, the public one is nothing but a marketing blurb. > >> Also, please break up patches to be sent one-per-email so they can be >> properly applied, and also only have them do one thing (your 4th patch >> fixed up coding style issues and added the driver to the build.) > > Okay, I will resend them. > >> Also, can you add a TODO file to the driver directory stating what is >> needed to be done, and who to contact about it? > > I will test the device over the coming week and add in a TODO after that. > > Thanks, > Manu > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Jon Smirl jonsmirl@gmail.com ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch staging] BCM70010 (crystalhd) Linux Driver 2010-01-02 22:03 ` Jon Smirl @ 2010-01-02 23:14 ` Manu Abraham 2010-01-03 4:51 ` Jarod Wilson 1 sibling, 0 replies; 11+ messages in thread From: Manu Abraham @ 2010-01-02 23:14 UTC (permalink / raw) To: Jon Smirl; +Cc: Greg KH, Peter Paul, linux-kernel On Sun, Jan 3, 2010 at 2:03 AM, Jon Smirl <jonsmirl@gmail.com> wrote: > On Sat, Jan 2, 2010 at 1:17 PM, Manu Abraham <abraham.manu@gmail.com> wrote: >> Hi Greg, >> >> On Sat, Jan 2, 2010 at 8:34 PM, Greg KH <greg@kroah.com> wrote: >>> On Sat, Jan 02, 2010 at 08:05:38PM +0400, Manu Abraham wrote: >>>> Hi Greg, >>>> >>>> > I'm glad to do so if someone wants to help work on it there and shephard >>>> > it into the main kernel tree. >>>> >>>> Please find the initial round of cleaned up patches for staging, >>>> applied against linux-next. >>> >>> Did you really author this driver? If so, that's fine, just checking. >>> If not, please put the correct authorship "From:" in the patch. >> >> I am not the author of the driver. I just picked it up and cleaned it >> up for Coding style changes for it to be included. > > I'm not against this submission, but would it be better to wait until > Monday when the Broadcom authors are back as see if they want to > submit their own driver? That way changes would end up back in their > internal VCS. Sure, of course, > I'd like to see a real datasheet for this chip, the public one is > nothing but a marketing blurb. You mean a user manual with a description of the registers, don't you ? Decoder datasheets from whichever manufacturer rarely come into public. Even with NDA's it is quite hard to get hold of a "proper one" Regards, Manu ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch staging] BCM70010 (crystalhd) Linux Driver 2010-01-02 22:03 ` Jon Smirl 2010-01-02 23:14 ` Manu Abraham @ 2010-01-03 4:51 ` Jarod Wilson 2010-01-03 17:34 ` Greg KH 1 sibling, 1 reply; 11+ messages in thread From: Jarod Wilson @ 2010-01-03 4:51 UTC (permalink / raw) To: Jon Smirl Cc: Manu Abraham, Greg KH, Peter Paul, linux-kernel, davilla, Jarod Wilson, nsankar On Sat, Jan 2, 2010 at 5:03 PM, Jon Smirl <jonsmirl@gmail.com> wrote: > On Sat, Jan 2, 2010 at 1:17 PM, Manu Abraham <abraham.manu@gmail.com> wrote: >> Hi Greg, >> >> On Sat, Jan 2, 2010 at 8:34 PM, Greg KH <greg@kroah.com> wrote: >>> On Sat, Jan 02, 2010 at 08:05:38PM +0400, Manu Abraham wrote: >>>> Hi Greg, >>>> >>>> > I'm glad to do so if someone wants to help work on it there and shephard >>>> > it into the main kernel tree. >>>> >>>> Please find the initial round of cleaned up patches for staging, >>>> applied against linux-next. >>> >>> Did you really author this driver? If so, that's fine, just checking. >>> If not, please put the correct authorship "From:" in the patch. >> >> I am not the author of the driver. I just picked it up and cleaned it >> up for Coding style changes for it to be included. > > I'm not against this submission, but would it be better to wait until > Monday when the Broadcom authors are back as see if they want to > submit their own driver? That way changes would end up back in their > internal VCS. Yes, please hold off a bit on this, I've actually been working on this driver with Scott and Naren (cc'd) for several months now (which is part of why it doesn't look so much like a lot of typical vendor code ;), and was planning to handle the submission on Naren and Broadcom's behalf. Just didn't expect someone else to hop on it this quickly. Was planning to get a git tree up on git.kernel.org over the weekend for both the driver and the lib, start prepping patches for review, etc., but family time and home improvement projects have taken precedence the past few days (not to mention a few other driver projects that sucked up time earlier in the break, *cough* IR). -- Jarod Wilson jarodwilson@gmail.com ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch staging] BCM70010 (crystalhd) Linux Driver 2010-01-03 4:51 ` Jarod Wilson @ 2010-01-03 17:34 ` Greg KH 0 siblings, 0 replies; 11+ messages in thread From: Greg KH @ 2010-01-03 17:34 UTC (permalink / raw) To: jarod; +Cc: Jon Smirl, Manu Abraham, Peter Paul, linux-kernel, davilla, nsankar On Sat, Jan 02, 2010 at 11:51:23PM -0500, Jarod Wilson wrote: > > I'm not against this submission, but would it be better to wait until > > Monday when the Broadcom authors are back as see if they want to > > submit their own driver? That way changes would end up back in their > > internal VCS. > > Yes, please hold off a bit on this, I've actually been working on this > driver with Scott and Naren (cc'd) for several months now (which is > part of why it doesn't look so much like a lot of typical vendor code > ;), and was planning to handle the submission on Naren and Broadcom's > behalf. Just didn't expect someone else to hop on it this quickly. Was > planning to get a git tree up on git.kernel.org over the weekend for > both the driver and the lib, start prepping patches for review, etc., > but family time and home improvement projects have taken precedence > the past few days (not to mention a few other driver projects that > sucked up time earlier in the break, *cough* IR). Ok, I'll ignore the patches from Manu for now, but please, do not create a git tree, just send me what you have right now, as obviously some people find it useful. Then, everyone can work on it together in the main kernel.org tree, like the rest of kernel development is done. If you have any questions about how to do this, please let me know. thanks, greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2010-01-03 21:15 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-30 20:06 BCM70010 (crystalhd) Linux Driver Peter Paul
2009-12-31 13:18 ` Andrey Panin
2010-01-01 0:19 ` Greg KH
[not found] ` <1a297b361001020805y6b00af83g81cf8492aa73bc3b@mail.gmail.com>
2010-01-02 16:34 ` [patch staging] " Greg KH
2010-01-02 18:17 ` Manu Abraham
2010-01-02 19:21 ` Greg KH
2010-01-02 20:08 ` Manu Abraham
2010-01-02 22:03 ` Jon Smirl
2010-01-02 23:14 ` Manu Abraham
2010-01-03 4:51 ` Jarod Wilson
2010-01-03 17:34 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox