* [PATCH] VLYNQ: add missing linux/irq.h include
@ 2010-01-04 17:38 Florian Fainelli
2010-01-04 18:12 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2010-01-04 17:38 UTC (permalink / raw)
To: linux-kernel, Andrew Morton
This patch adds the missing linux/irq.h header
which will trigger compilation errors on non-AR7
platforms (i.e: TI Davinci).
Reported-by: Rohan Tabish <rohan_javed@yahoo.co.uk>
Signed-off-by: Regards, Florian Fainelli <florian@openwrt.org>
---
diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
index 9554ad5..14b1af9 100644
--- a/drivers/vlynq/vlynq.c
+++ b/drivers/vlynq/vlynq.c
@@ -30,6 +30,7 @@
#include <linux/interrupt.h>
#include <linux/delay.h>
#include <linux/io.h>
+#include <linux/irq.h>
#include <linux/vlynq.h>
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] VLYNQ: add missing linux/irq.h include
2010-01-04 17:38 [PATCH] VLYNQ: add missing linux/irq.h include Florian Fainelli
@ 2010-01-04 18:12 ` Christoph Hellwig
2010-01-04 20:22 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2010-01-04 18:12 UTC (permalink / raw)
To: Florian Fainelli; +Cc: linux-kernel, Andrew Morton
On Mon, Jan 04, 2010 at 06:38:51PM +0100, Florian Fainelli wrote:
> This patch adds the missing linux/irq.h header
> which will trigger compilation errors on non-AR7
> platforms (i.e: TI Davinci).
linux/irq.h should not be included by drivers. It's an internal handler
for the generic hardirq code. All functions for use by drivers are in
linux/interrupt.h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] VLYNQ: add missing linux/irq.h include
2010-01-04 18:12 ` Christoph Hellwig
@ 2010-01-04 20:22 ` Florian Fainelli
0 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2010-01-04 20:22 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-kernel, Andrew Morton
Hi Christoph,
Le lundi 4 janvier 2010 19:12:28, Christoph Hellwig a écrit :
> On Mon, Jan 04, 2010 at 06:38:51PM +0100, Florian Fainelli wrote:
> > This patch adds the missing linux/irq.h header
> > which will trigger compilation errors on non-AR7
> > platforms (i.e: TI Davinci).
>
> linux/irq.h should not be included by drivers. It's an internal handler
> for the generic hardirq code. All functions for use by drivers are in
> linux/interrupt.h
vlynq.c references definitions that are in linux/irq.h and not in
linux/interrupt.h (like IRQ_TYPE_*), thus the include.
--
Best regards, Florian Fainelli
Email: florian@openwrt.org
Web: http://openwrt.org
IRC: [florian] on irc.freenode.net
-------------------------------
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-04 20:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-04 17:38 [PATCH] VLYNQ: add missing linux/irq.h include Florian Fainelli
2010-01-04 18:12 ` Christoph Hellwig
2010-01-04 20:22 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox