Re: [PATCH] drivers/message/i2o/i2o_proc.c: use %pM to show MAC address

Joe Perches
2009-12-30T19:33:15Z

On Wed, 2009-12-30 at 14:22 -0500, H Hartley Sweeten wrote:
> Use the %pM kernel extension to display the MAC address.
> diff --git a/drivers/message/i2o/i2o_proc.c b/drivers/message/i2o/i2o_proc.c
> index 7045c45..949a648 100644
> --- a/drivers/message/i2o/i2o_proc.c
> +++ b/drivers/message/i2o/i2o_proc.c
> @@ -111,10 +111,7 @@ static int print_serial_number(struct seq_file *seq, u8 * serialno, int max_len)
> break;
>
> case I2O_SNFORMAT_LAN48_MAC: /* LAN-48 MAC Address */
> - seq_printf(seq,
> - "LAN-48 MAC address @ %02X:%02X:%02X:%02X:%02X:%02X",
> - serialno[2], serialno[3],
> - serialno[4], serialno[5], serialno[6], serialno[7]);
> + seq_printf(seq, "LAN-48 MAC address @ %pM", &serialno[2]);
> break;
>
> case I2O_SNFORMAT_WAN: /* WAN MAC Address */
> @@ -126,10 +123,8 @@ static int print_serial_number(struct seq_file *seq, u8 * serialno, int max_len)
> case I2O_SNFORMAT_LAN64_MAC: /* LAN-64 MAC Address */
> /* FIXME: Figure out what a LAN-64 address really looks like?? */
> seq_printf(seq,
> - "LAN-64 MAC address @ [?:%02X:%02X:?] %02X:%02X:%02X:%02X:%02X:%02X",
> - serialno[8], serialno[9],
> - serialno[2], serialno[3],
> - serialno[4], serialno[5], serialno[6], serialno[7]);
> + "LAN-64 MAC address @ [?:%02X:%02X:?] %pM",
> + serialno[8], serialno[9], &serialno[2]);

User visible change but low probability to break things