public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Revert "x86: Side-step lguest problem by only building cmpxchg8b_emu for pre-Pentium"
@ 2010-01-05  2:18 Rusty Russell
  2010-01-05  4:48 ` [tip:x86/urgent] " tip-bot for Rusty Russell
  0 siblings, 1 reply; 2+ messages in thread
From: Rusty Russell @ 2010-01-05  2:18 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Linus Torvalds, H. Anvin, linux-kernel

This reverts commit ae1b22f6e46c03cede7cea234d0bf2253b4261cf.
    
As Linus said in 982d007a6ee: "There was something really messy about
cmpxchg8b and clone CPU's, so if you enable it on other CPUs later, do it
carefully."
    
This breaks lguest for those configs, but we can fix that by emulating
if we have to.
    
Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=14884
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: stable@kernel.org
---
 arch/x86/Kconfig.cpu |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/Kconfig.cpu b/arch/x86/Kconfig.cpu
index 08e442b..f20ddf8 100644
--- a/arch/x86/Kconfig.cpu
+++ b/arch/x86/Kconfig.cpu
@@ -396,7 +396,7 @@ config X86_TSC
 
 config X86_CMPXCHG64
 	def_bool y
-	depends on !M386 && !M486
+	depends on X86_PAE || X86_64 || MCORE2 || MPENTIUM4 || MPENTIUMM || MPENTIUMIII || MPENTIUMII || M686 || MATOM
 
 # this should be set for all -march=.. options where the compiler
 # generates cmov.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip:x86/urgent] Revert "x86: Side-step lguest problem by only building cmpxchg8b_emu for pre-Pentium"
  2010-01-05  2:18 [PATCH] Revert "x86: Side-step lguest problem by only building cmpxchg8b_emu for pre-Pentium" Rusty Russell
@ 2010-01-05  4:48 ` tip-bot for Rusty Russell
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Rusty Russell @ 2010-01-05  4:48 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, rusty, tglx

Commit-ID:  f4b825bde98938f160315d655597bc9731521cae
Gitweb:     http://git.kernel.org/tip/f4b825bde98938f160315d655597bc9731521cae
Author:     Rusty Russell <rusty@rustcorp.com.au>
AuthorDate: Tue, 5 Jan 2010 12:48:49 +1030
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Mon, 4 Jan 2010 19:35:49 -0800

Revert "x86: Side-step lguest problem by only building cmpxchg8b_emu for pre-Pentium"

This reverts commit ae1b22f6e46c03cede7cea234d0bf2253b4261cf.

As Linus said in 982d007a6ee: "There was something really messy about
cmpxchg8b and clone CPU's, so if you enable it on other CPUs later, do it
carefully."

This breaks lguest for those configs, but we can fix that by emulating
if we have to.

Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=14884
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
LKML-Reference: <201001051248.49700.rusty@rustcorp.com.au>
Cc: stable@kernel.org
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
 arch/x86/Kconfig.cpu |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/Kconfig.cpu b/arch/x86/Kconfig.cpu
index 08e442b..f20ddf8 100644
--- a/arch/x86/Kconfig.cpu
+++ b/arch/x86/Kconfig.cpu
@@ -396,7 +396,7 @@ config X86_TSC
 
 config X86_CMPXCHG64
 	def_bool y
-	depends on !M386 && !M486
+	depends on X86_PAE || X86_64 || MCORE2 || MPENTIUM4 || MPENTIUMM || MPENTIUMIII || MPENTIUMII || M686 || MATOM
 
 # this should be set for all -march=.. options where the compiler
 # generates cmov.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-01-05  4:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-05  2:18 [PATCH] Revert "x86: Side-step lguest problem by only building cmpxchg8b_emu for pre-Pentium" Rusty Russell
2010-01-05  4:48 ` [tip:x86/urgent] " tip-bot for Rusty Russell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox