* [PATCH] pca953x: Minor include cleanup
@ 2010-01-05 20:10 Olof Johansson
2010-01-05 20:21 ` Wolfram Sang
0 siblings, 1 reply; 5+ messages in thread
From: Olof Johansson @ 2010-01-05 20:10 UTC (permalink / raw)
To: ben-linux; +Cc: linux-kernel, linux-i2c
linux/i2c/pca953x.h is a very bare include file. Fix check for multiple
includes of linux/i2c/pca953x.h, and add dependent includes into the
header file.
Signed-off-by: Olof Johansson <olof@lixom.net>
diff --git a/include/linux/i2c/pca953x.h b/include/linux/i2c/pca953x.h
index 81736d6..29699f8 100644
--- a/include/linux/i2c/pca953x.h
+++ b/include/linux/i2c/pca953x.h
@@ -1,3 +1,9 @@
+#ifndef _LINUX_PCA953X_H
+#define _LINUX_PCA953X_H
+
+#include <linux/types.h>
+#include <linux/i2c.h>
+
/* platform data for the PCA9539 16-bit I/O expander driver */
struct pca953x_platform_data {
@@ -17,3 +23,5 @@ struct pca953x_platform_data {
void *context);
char **names;
};
+
+#endif /* _LINUX_PCA953X_H */
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] pca953x: Minor include cleanup
2010-01-05 20:10 [PATCH] pca953x: Minor include cleanup Olof Johansson
@ 2010-01-05 20:21 ` Wolfram Sang
2010-01-06 11:17 ` Jean Delvare
0 siblings, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2010-01-05 20:21 UTC (permalink / raw)
To: Olof Johansson; +Cc: ben-linux, linux-kernel, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
On Tue, Jan 05, 2010 at 02:10:42PM -0600, Olof Johansson wrote:
> linux/i2c/pca953x.h is a very bare include file. Fix check for multiple
> includes of linux/i2c/pca953x.h, and add dependent includes into the
> header file.
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pca953x: Minor include cleanup
2010-01-05 20:21 ` Wolfram Sang
@ 2010-01-06 11:17 ` Jean Delvare
2010-01-08 21:34 ` Olof Johansson
0 siblings, 1 reply; 5+ messages in thread
From: Jean Delvare @ 2010-01-06 11:17 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Olof Johansson, ben-linux, linux-kernel, linux-i2c
On Tue, 5 Jan 2010 21:21:58 +0100, Wolfram Sang wrote:
> On Tue, Jan 05, 2010 at 02:10:42PM -0600, Olof Johansson wrote:
> > linux/i2c/pca953x.h is a very bare include file. Fix check for multiple
> > includes of linux/i2c/pca953x.h, and add dependent includes into the
> > header file.
> >
> > Signed-off-by: Olof Johansson <olof@lixom.net>
>
> Acked-by: Wolfram Sang <w.sang@pengutronix.de>
And also
Acked-by: Jean Delvare <khali@linux-fr.org>
Note though that this file is not part of the i2c subsystem. Your patch
is something for the gpio people.
--
Jean Delvare
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pca953x: Minor include cleanup
2010-01-06 11:17 ` Jean Delvare
@ 2010-01-08 21:34 ` Olof Johansson
2010-01-09 10:58 ` Jean Delvare
0 siblings, 1 reply; 5+ messages in thread
From: Olof Johansson @ 2010-01-08 21:34 UTC (permalink / raw)
To: Jean Delvare; +Cc: Wolfram Sang, ben-linux, linux-kernel, linux-i2c, akpm
On Wed, Jan 06, 2010 at 12:17:22PM +0100, Jean Delvare wrote:
> On Tue, 5 Jan 2010 21:21:58 +0100, Wolfram Sang wrote:
> > On Tue, Jan 05, 2010 at 02:10:42PM -0600, Olof Johansson wrote:
> > > linux/i2c/pca953x.h is a very bare include file. Fix check for multiple
> > > includes of linux/i2c/pca953x.h, and add dependent includes into the
> > > header file.
> > >
> > > Signed-off-by: Olof Johansson <olof@lixom.net>
> >
> > Acked-by: Wolfram Sang <w.sang@pengutronix.de>
>
> And also
>
> Acked-by: Jean Delvare <khali@linux-fr.org>
>
> Note though that this file is not part of the i2c subsystem. Your patch
> is something for the gpio people.
Boggle. No GPIO maintianer (nor list) mentioned in MAINTAINERS. I
don't see any common merge paths in the git log of drivers/gpio either,
besides akpm.
So I guess I'll ask him to pick it up.
Andrew: Want a fresh copy of the patch?
-Olof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pca953x: Minor include cleanup
2010-01-08 21:34 ` Olof Johansson
@ 2010-01-09 10:58 ` Jean Delvare
0 siblings, 0 replies; 5+ messages in thread
From: Jean Delvare @ 2010-01-09 10:58 UTC (permalink / raw)
To: Olof Johansson; +Cc: Wolfram Sang, ben-linux, linux-kernel, linux-i2c, akpm
Hi Olof,
On Fri, 8 Jan 2010 15:34:15 -0600, Olof Johansson wrote:
> Boggle. No GPIO maintianer (nor list) mentioned in MAINTAINERS. I
> don't see any common merge paths in the git log of drivers/gpio either,
> besides akpm.
Correct. Feel free to step in ;)
--
Jean Delvare
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-01-09 10:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-05 20:10 [PATCH] pca953x: Minor include cleanup Olof Johansson
2010-01-05 20:21 ` Wolfram Sang
2010-01-06 11:17 ` Jean Delvare
2010-01-08 21:34 ` Olof Johansson
2010-01-09 10:58 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox