public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: [patch 6/6] x86: cpumask_of_node() should handle -1 as a node
Date: Wed, 06 Jan 2010 15:55:15 +1100	[thread overview]
Message-ID: <20100106045525.476396870@samba.org> (raw)
In-Reply-To: 20100106045509.245662398@samba.org

pcibus_to_node can return -1 if we cannot determine which node a pci bus
is on. If passed -1, cpumask_of_node will negatively index the lookup array
and pull in random data:

# cat /sys/devices/pci0000:00/0000:00:01.0/local_cpus
00000000,00000003,00000000,00000000
# cat /sys/devices/pci0000:00/0000:00:01.0/local_cpulist
64-65

Change cpumask_of_node to check for -1 and return cpu_all_mask in this
case:

# cat /sys/devices/pci0000:00/0000:00:01.0/local_cpus
ffffffff,ffffffff,ffffffff,ffffffff
# cat /sys/devices/pci0000:00/0000:00:01.0/local_cpulist
0-127

Signed-off-by: Anton Blanchard <anton@samba.org>
---

diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topology.h
index c5087d7..cc4f136 100644
--- a/arch/x86/include/asm/topology.h
+++ b/arch/x86/include/asm/topology.h
@@ -99,7 +99,8 @@ extern const struct cpumask *cpumask_of_node(int node);
 /* Returns a pointer to the cpumask of CPUs on Node 'node'. */
 static inline const struct cpumask *cpumask_of_node(int node)
 {
-	return node_to_cpumask_map[node];
+	return (node == -1) ? cpu_all_mask :
+		node_to_cpumask_map[node];
 }
 #endif
 
diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
index 550df48..e57a7f5 100644
--- a/arch/x86/mm/numa.c
+++ b/arch/x86/mm/numa.c
@@ -47,6 +47,9 @@ void __init setup_node_to_cpumask_map(void)
  */
 const struct cpumask *cpumask_of_node(int node)
 {
+	if (node == -1)
+		return cpu_all_mask;
+
 	if (node >= nr_node_ids) {
 		printk(KERN_WARNING
 			"cpumask_of_node(%d): node > nr_node_ids(%d)\n",

-- 


  parent reply	other threads:[~2010-01-06  6:11 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-06  4:55 [patch 0/6] cpumask_of_node() should handle -1 as a node Anton Blanchard
2010-01-06  4:55 ` [patch 1/6] powerpc: " Anton Blanchard
2010-01-06  4:55 ` [patch 2/6] alpha: " Anton Blanchard
2010-01-14 18:24   ` Matt Turner
2010-01-06  4:55 ` [patch 3/6] ia64: " Anton Blanchard
2010-01-06  4:55 ` [patch 4/6] mips: " Anton Blanchard
2010-01-11 10:42   ` Ralf Baechle
2010-01-06  4:55 ` [patch 5/6] sparc: " Anton Blanchard
2010-01-07  4:22   ` David Miller
2010-01-06  4:55 ` Anton Blanchard [this message]
2010-01-06  6:36   ` [patch 6/6] x86: " Rusty Russell
2010-01-06 23:00     ` David Rientjes
2010-01-06 23:31       ` Anton Blanchard
2010-01-06 23:51         ` David Rientjes
2010-01-07  0:01           ` Anton Blanchard
2010-01-07  0:25             ` David Rientjes
2010-01-07  0:39           ` Rusty Russell
2010-01-07  8:04             ` David Rientjes
2010-01-06 23:20     ` Anton Blanchard
2010-01-11 22:11 ` [patch 0/6] " Andrew Morton
2010-01-12  1:07   ` Anton Blanchard
2010-01-12  2:04   ` Anton Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100106045525.476396870@samba.org \
    --to=anton@samba.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox