From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932923Ab0AFWCz (ORCPT ); Wed, 6 Jan 2010 17:02:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755952Ab0AFWCy (ORCPT ); Wed, 6 Jan 2010 17:02:54 -0500 Received: from cavan.codon.org.uk ([93.93.128.6]:57435 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755884Ab0AFWCx (ORCPT ); Wed, 6 Jan 2010 17:02:53 -0500 Date: Wed, 6 Jan 2010 22:02:14 +0000 From: Matthew Garrett To: Jesse Barnes Cc: "Rafael J. Wysocki" , Len Brown , LKML , pm list , Alan Stern , ACPI Devel Maling List , Linux PCI , Oliver Neukum , Bjorn Helgaas , Shaohua Li , Francois Romieu Subject: Re: [PATCH 4/12] PCI PM: Make it possible to force using INTx for PCIe PME signaling Message-ID: <20100106220214.GA25366@srcf.ucam.org> References: <200912272057.10443.rjw@sisk.pl> <200912272102.22775.rjw@sisk.pl> <20100106135625.14b37f10@jbarnes-piketon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100106135625.14b37f10@jbarnes-piketon> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 06, 2010 at 01:56:25PM -0800, Jesse Barnes wrote: > This scares me a little... seems like we're not restoring some state on > resume that's needed for MSIs to work? Looks fine though. Yeah, that was my concern. We debugged this a little on IRC and didn't get anywhere, though, so probably need to find someone who knows more about MSIs... -- Matthew Garrett | mjg59@srcf.ucam.org