* [PATCH] mtd/nand: Fix build failure caused by typo
@ 2010-01-07 2:01 Peter Hüwe
2010-01-07 2:16 ` H Hartley Sweeten
0 siblings, 1 reply; 3+ messages in thread
From: Peter Hüwe @ 2010-01-07 2:01 UTC (permalink / raw)
To: David Woodhouse
Cc: H Hartley Sweeten, Nicolas Pitre, Uwe Kleine-König,
Andrew Morton, linux-mtd, linux-kernel
From: Peter Huewe <peterhuewe@gmx.de>
Date: Thu, 7 Jan 2010 02:51:13 +0100
This patch fixes a build failure[1] introduced by the patch
mtd: orion_nand.c: add error handling and use resource_size()
by H Hartley Sweeten [2]
The patch assigns something to a undeclared variable 'err', whereas the
rest of the code uses 'ret' for this task.
This patch fixes this typo and thus removes the build failure.
References:
[1] http://kisskb.ellerman.id.au/kisskb/buildresult/1983354/
[2] http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=e99030609e27abff7e1a868cb56384c678b09984
Patch against linux-next of Do 7. Jan 02:58:41 CET 2010
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
drivers/mtd/nand/orion_nand.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
index 9903460..f16050c 100644
--- a/drivers/mtd/nand/orion_nand.c
+++ b/drivers/mtd/nand/orion_nand.c
@@ -92,7 +92,7 @@ static int __init orion_nand_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) {
- err = -ENODEV;
+ ret = -ENODEV;
goto no_res;
}
--
1.6.4.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] mtd/nand: Fix build failure caused by typo
2010-01-07 2:01 [PATCH] mtd/nand: Fix build failure caused by typo Peter Hüwe
@ 2010-01-07 2:16 ` H Hartley Sweeten
2010-01-07 8:37 ` Uwe Kleine-König
0 siblings, 1 reply; 3+ messages in thread
From: H Hartley Sweeten @ 2010-01-07 2:16 UTC (permalink / raw)
To: Peter Hüwe, David Woodhouse
Cc: Nicolas Pitre, Uwe Kleine-König, Andrew Morton, linux-mtd,
linux-kernel
On Wednesday, January 06, 2010 7:02 PM, Peter Hüwe wrote:
> From: Peter Huewe <peterhuewe@gmx.de>
> Date: Thu, 7 Jan 2010 02:51:13 +0100
>
> This patch fixes a build failure[1] introduced by the patch
> mtd: orion_nand.c: add error handling and use resource_size()
> by H Hartley Sweeten [2]
> The patch assigns something to a undeclared variable 'err', whereas the
> rest of the code uses 'ret' for this task.
>
> This patch fixes this typo and thus removes the build failure.
>
> References:
> [1] http://kisskb.ellerman.id.au/kisskb/buildresult/1983354/
> [2] http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=e99030609e27abff7e1a868cb56384c678b09984
>
> Patch against linux-next of Do 7. Jan 02:58:41 CET 2010
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
> drivers/mtd/nand/orion_nand.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
> index 9903460..f16050c 100644
> --- a/drivers/mtd/nand/orion_nand.c
> +++ b/drivers/mtd/nand/orion_nand.c
> @@ -92,7 +92,7 @@ static int __init orion_nand_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!res) {
> - err = -ENODEV;
> + ret = -ENODEV;
> goto no_res;
> }
Sorry about that.
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mtd/nand: Fix build failure caused by typo
2010-01-07 2:16 ` H Hartley Sweeten
@ 2010-01-07 8:37 ` Uwe Kleine-König
0 siblings, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2010-01-07 8:37 UTC (permalink / raw)
To: H Hartley Sweeten
Cc: Peter Hüwe, David Woodhouse, Nicolas Pitre, Andrew Morton,
linux-mtd, linux-kernel
Hello,
> > This patch fixes a build failure[1] introduced by the patch
> > mtd: orion_nand.c: add error handling and use resource_size()
> > by H Hartley Sweeten [2]
> > The patch assigns something to a undeclared variable 'err', whereas the
> > rest of the code uses 'ret' for this task.
> >
> > This patch fixes this typo and thus removes the build failure.
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-07 8:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-07 2:01 [PATCH] mtd/nand: Fix build failure caused by typo Peter Hüwe
2010-01-07 2:16 ` H Hartley Sweeten
2010-01-07 8:37 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox