Re: [PATCH] Convert the AB3100 driver to use threaded IRH

Samuel Ortiz
2010-01-08T11:08:49Z

On Fri, Jan 08, 2010 at 11:09:31AM +0100, Linus Walleij wrote:
> 2010/1/8 Samuel Ortiz <sameo@linux.intel.com>:
>
> > Linus, I fogot to mention that I removed IRQF_SAMPLE_RANDOM from your
> > request_threaded_irq() arguments, as it is scheduled for removal. See
> > Documentation/feature-removal-schedule.txt.
> > Please let me know if that's a problem for you.
>
> I got the warning from checkpatch as well, and since this is an
> interrupt source which is truly random and we really *want* to sample
> for some IRQ randomness I do want that functionality in there.
>
> However the fucntions to be used instead,
> rand_initialize_irq() + add_interrupt_randomness() aren't used
> anywhere else in the kernel than in the interrupt driver core.
>
> But I don't mind being first ... if you upload your git tree to
> git.kernel.org I'll make a patch to reenable this the right way.
> (Or I can rewrite the previous patch, your choice.)
I'll push your patch without IRQF_SAMPLE_RANDOM to my for-next branch. Feel
free to send me a patch against it.

Cheers,
Samuel.

> Linus