public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: suresh.b.siddha@intel.com,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: yinghai@kernel.org, Ingo Molnar <mingo@elte.hu>,
	lkml <linux-kernel@vger.kernel.org>,
	stable@kernel.org
Subject: [PATCH] Make Intel 8-way Xeons boot again
Date: Sat, 9 Jan 2010 15:40:38 +0530	[thread overview]
Message-ID: <20100109101038.GA17555@in.ibm.com> (raw)

On an 8-way system with Intel Xeon X7350 CPUs, booting 2.6.32 or newer
kernels fails at:

...
CPU0: Intel(R) Xeon(R) CPU           X7350  @ 2.93GHz stepping 0b
Booting Node   0, Processors  #1 #2 #3 #4 #5 #6 #7 Ok.
Brought up 8 CPUs
Total of 8 processors activated (46906.05 BogoMIPS).

Git bisect showed 2fbd07a5f as the offending commit.

With the patch below, I am able to boot the latest Linus' git tree on
the machine. If this patch is correct, it needs to get into the stable
tree too.

Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
---
Index: linux-2.6/arch/x86/kernel/apic/probe_64.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/apic/probe_64.c	2010-01-09 14:54:29.000000000 +0530
+++ linux-2.6/arch/x86/kernel/apic/probe_64.c	2010-01-09 14:57:53.000000000 +0530
@@ -70,7 +70,7 @@
 	if (apic == &apic_flat) {
 		switch (boot_cpu_data.x86_vendor) {
 		case X86_VENDOR_INTEL:
-			if (num_processors > 8)
+			if (num_processors >= 8)
 				apic = &apic_physflat;
 			break;
 		case X86_VENDOR_AMD:

             reply	other threads:[~2010-01-09 10:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-09 10:10 Ananth N Mavinakayanahalli [this message]
2010-01-09 18:11 ` [PATCH] Make Intel 8-way Xeons boot again Linus Torvalds
2010-01-09 22:51   ` Yinghai Lu
2010-01-11 17:38   ` Suresh Siddha
2010-01-09 21:13 ` Yinghai Lu
2010-01-10  2:30   ` Ananth N Mavinakayanahalli
2010-01-10  6:35     ` Yinghai Lu
2010-01-10 10:26       ` Ingo Molnar
2010-01-11  4:53         ` [PATCH] Revert 2fbd07a5f so machines with BSPs phsyical apic id != 0 can boot Ananth N Mavinakayanahalli
2010-01-11 21:39           ` Suresh Siddha
2010-01-11 22:55             ` Linus Torvalds
2010-01-11 23:45               ` Suresh Siddha
2010-01-11 23:51                 ` Suresh Siddha
2010-01-12  0:46                 ` Linus Torvalds
2010-01-12  0:50                   ` Linus Torvalds
2010-01-12  2:27                   ` Suresh Siddha
2010-01-14  0:03           ` Yuhong Bao
2010-01-11 21:43         ` [PATCH] Make Intel 8-way Xeons boot again Yinghai Lu
2010-01-11 21:53           ` Suresh Siddha
2010-01-12 19:10             ` Yinghai Lu
2010-01-12 20:20               ` Suresh Siddha
2010-01-12 21:02                 ` H. Peter Anvin
2010-01-12 21:07                   ` Suresh Siddha
2010-01-12 22:46     ` Suresh Siddha
2010-01-13  4:42       ` Ananth N Mavinakayanahalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100109101038.GA17555@in.ibm.com \
    --to=ananth@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stable@kernel.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox