* [PATCH] rtc: mxc: fix memory leak
@ 2010-01-09 16:43 Alexander Beregalov
2010-01-09 17:01 ` Américo Wang
2010-01-09 18:53 ` Daniel Mack
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Beregalov @ 2010-01-09 16:43 UTC (permalink / raw)
To: akpm, daniel; +Cc: linux-kernel, Alexander Beregalov
Free pdata before exit.
Found by cppcheck.
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---
drivers/rtc/rtc-mxc.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c
index 6bd5072..2642e6b 100644
--- a/drivers/rtc/rtc-mxc.c
+++ b/drivers/rtc/rtc-mxc.c
@@ -396,8 +396,10 @@ static int __init mxc_rtc_probe(struct platform_device *pdev)
pdata->ioaddr = ioremap(res->start, resource_size(res));
clk = clk_get(&pdev->dev, "ckil");
- if (IS_ERR(clk))
- return PTR_ERR(clk);
+ if (IS_ERR(clk)) {
+ ret = PTR_ERR(clk);
+ goto exit_free_pdata;
+ }
rate = clk_get_rate(clk);
clk_put(clk);
--
1.6.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] rtc: mxc: fix memory leak
2010-01-09 16:43 [PATCH] rtc: mxc: fix memory leak Alexander Beregalov
@ 2010-01-09 17:01 ` Américo Wang
2010-01-09 18:53 ` Daniel Mack
1 sibling, 0 replies; 3+ messages in thread
From: Américo Wang @ 2010-01-09 17:01 UTC (permalink / raw)
To: Alexander Beregalov; +Cc: akpm, daniel, linux-kernel
On Sat, Jan 09, 2010 at 07:43:07PM +0300, Alexander Beregalov wrote:
>Free pdata before exit.
>Found by cppcheck.
>
>Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
This patch looks fine for me.
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
Thanks!
>---
> drivers/rtc/rtc-mxc.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c
>index 6bd5072..2642e6b 100644
>--- a/drivers/rtc/rtc-mxc.c
>+++ b/drivers/rtc/rtc-mxc.c
>@@ -396,8 +396,10 @@ static int __init mxc_rtc_probe(struct platform_device *pdev)
> pdata->ioaddr = ioremap(res->start, resource_size(res));
>
> clk = clk_get(&pdev->dev, "ckil");
>- if (IS_ERR(clk))
>- return PTR_ERR(clk);
>+ if (IS_ERR(clk)) {
>+ ret = PTR_ERR(clk);
>+ goto exit_free_pdata;
>+ }
>
> rate = clk_get_rate(clk);
> clk_put(clk);
>--
>1.6.6
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
--
Live like a child, think like the god.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rtc: mxc: fix memory leak
2010-01-09 16:43 [PATCH] rtc: mxc: fix memory leak Alexander Beregalov
2010-01-09 17:01 ` Américo Wang
@ 2010-01-09 18:53 ` Daniel Mack
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Mack @ 2010-01-09 18:53 UTC (permalink / raw)
To: Alexander Beregalov; +Cc: akpm, linux-kernel
On Sat, Jan 09, 2010 at 07:43:07PM +0300, Alexander Beregalov wrote:
> Free pdata before exit.
> Found by cppcheck.
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Acked-by: Daniel Mack <daniel@caiaq.de>
> ---
> drivers/rtc/rtc-mxc.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c
> index 6bd5072..2642e6b 100644
> --- a/drivers/rtc/rtc-mxc.c
> +++ b/drivers/rtc/rtc-mxc.c
> @@ -396,8 +396,10 @@ static int __init mxc_rtc_probe(struct platform_device *pdev)
> pdata->ioaddr = ioremap(res->start, resource_size(res));
>
> clk = clk_get(&pdev->dev, "ckil");
> - if (IS_ERR(clk))
> - return PTR_ERR(clk);
> + if (IS_ERR(clk)) {
> + ret = PTR_ERR(clk);
> + goto exit_free_pdata;
> + }
>
> rate = clk_get_rate(clk);
> clk_put(clk);
> --
> 1.6.6
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-09 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-09 16:43 [PATCH] rtc: mxc: fix memory leak Alexander Beregalov
2010-01-09 17:01 ` Américo Wang
2010-01-09 18:53 ` Daniel Mack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox