The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Brian Gerst <brgerst@gmail.com>
Cc: Christian Kujau <lists@nerdbynature.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.33-rc2: Xen/Guest switching to user mode with no user page tables
Date: Sun, 10 Jan 2010 11:09:40 +0300	[thread overview]
Message-ID: <20100110080940.GB5189@lenovo> (raw)
In-Reply-To: <73c1f2161001091750y67a852dfk7539021dcc82fa1f@mail.gmail.com>

On Sat, Jan 09, 2010 at 08:50:04PM -0500, Brian Gerst wrote:
...
> > ---
> > x86: kernel_thread -- initialize SS to a known state
> >
> > Before the kernel_thread was converted into "C" we had
> > pt_regs::ss set to __KERNEL_DS (by SAVE_ALL asm macro).
> >
> > Though I must admit I didn't find any *explicit* load of
> > %ss from this structure the better to be on a safe side
> > and set it to a known value.
> 
> It shouldn't make any difference, but maybe Xen is doing something
> subtle.  In 64-bit mode the %ss segment register is supposed to be
> ignored, which is why it is left set to zero.  It works properly on
> real hardware.  It can't hurt anything to put __KERNEL_DS back in, but
> I'd just like to know why Xen requires it if this does fix it.

Yeah, I didn't found any explicit %ss reloading for this _particular_
case (as I marked in patch changelog). So the only suspicious is Xen
itself. So as only Christian get ability to test -- we will see the
results.

> 
> --
> Brian Gerst
> 
	-- Cyrill

  reply	other threads:[~2010-01-10  8:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-06  1:03 2.6.33-rc2: Xen/Guest switching to user mode with no user page tables Christian Kujau
2010-01-06  3:38 ` Jeremy Fitzhardinge
2010-01-06  3:48   ` Christian Kujau
2010-01-06  5:14     ` Jeremy Fitzhardinge
2010-01-06 11:06   ` Christian Kujau
2010-01-06 11:21     ` Cyrill Gorcunov
2010-01-06 12:43       ` Christian Kujau
2010-01-07 19:06         ` Christian Kujau
2010-01-07 19:20           ` Cyrill Gorcunov
2010-01-07 19:31             ` Christian Kujau
2010-01-07 19:34               ` Cyrill Gorcunov
2010-01-07 19:19         ` H. Peter Anvin
2010-01-07 19:30           ` Christian Kujau
2010-01-08 21:50             ` Cyrill Gorcunov
2010-01-09 23:55               ` Christian Kujau
2010-01-10  1:50               ` Brian Gerst
2010-01-10  8:09                 ` Cyrill Gorcunov [this message]
2010-01-10 12:59                   ` Ian Campbell
2010-01-10 13:36                     ` Cyrill Gorcunov
2010-01-10 13:49                       ` Cyrill Gorcunov
2010-01-10 14:05                         ` Ian Campbell
2010-01-15  8:36                     ` Christian Kujau
2010-01-15 11:29                       ` Ian Campbell
2010-01-15 12:03                         ` Cyrill Gorcunov
2010-01-15 12:00                       ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100110080940.GB5189@lenovo \
    --to=gorcunov@gmail.com \
    --cc=brgerst@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lists@nerdbynature.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox