* [PATCH] HTC Dream camera, not need sizeof
@ 2010-01-11 18:08 Pavel Vasilyev
2010-01-11 18:47 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Vasilyev @ 2010-01-11 18:08 UTC (permalink / raw)
To: linux-kernel, drivers_staging, greg
http://bugzilla.kernel.org/show_bug.cgi?id=14825
Kernel version: git master (2.6.33-rc3-git3)
Description:
sizeof(extlen), always will be sizeof( unit32_t) or 4
It seems that something is wrong?!?!
-------
diff --git a/drivers/staging/dream/camera/msm_vfe7x.c
b/drivers/staging/dream/camera/msm_vfe7x.c
index 33ab3ac..4d39848 100644
--- a/drivers/staging/dream/camera/msm_vfe7x.c
+++ b/drivers/staging/dream/camera/msm_vfe7x.c
@@ -256,7 +256,7 @@ static int vfe_7x_init(struct msm_vfe_callback *presp,
extlen = sizeof(struct vfe_frame_extra);
extdata =
- kmalloc(sizeof(extlen), GFP_ATOMIC);
+ kmalloc(extlen, GFP_ATOMIC);
if (!extdata) {
rc = -ENOMEM;
goto init_fail;
----
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HTC Dream camera, not need sizeof
2010-01-11 18:08 [PATCH] HTC Dream camera, not need sizeof Pavel Vasilyev
@ 2010-01-11 18:47 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2010-01-11 18:47 UTC (permalink / raw)
To: Pavel Vasilyev; +Cc: linux-kernel, drivers_staging
On Mon, Jan 11, 2010 at 09:08:02PM +0300, Pavel Vasilyev wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=14825
>
> Kernel version: git master (2.6.33-rc3-git3)
>
>
> Description:
>
> sizeof(extlen), always will be sizeof( unit32_t) or 4
> It seems that something is wrong?!?!
Can I get a "Signed-off-by:" for this patch so that I can apply it to
the tree?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-11 18:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-11 18:08 [PATCH] HTC Dream camera, not need sizeof Pavel Vasilyev
2010-01-11 18:47 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox