From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754459Ab0AKUeL (ORCPT ); Mon, 11 Jan 2010 15:34:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754148Ab0AKUeJ (ORCPT ); Mon, 11 Jan 2010 15:34:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12494 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754159Ab0AKUeJ (ORCPT ); Mon, 11 Jan 2010 15:34:09 -0500 Date: Mon, 11 Jan 2010 15:33:56 -0500 From: Don Zickus To: Cyrill Gorcunov Cc: mingo@elte.hu, aris@redhat.com, linux-kernel@vger.kernel.org Subject: Re: introduce NMI_AUTO as nmi_watchdog option Message-ID: <20100111203356.GU24885@redhat.com> References: <20100111191633.GT24885@redhat.com> <20100111202729.GI4923@lenovo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100111202729.GI4923@lenovo> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2010 at 11:27:29PM +0300, Cyrill Gorcunov wrote: > On Mon, Jan 11, 2010 at 02:16:33PM -0500, Don Zickus wrote: > > Hi Ingo, > > > ... > > I was going to jump in and try to do this work. I wanted to make sure > > what you were looking for here. When you say convert nmi watchdog to perf > > events, I assume you mean merging over the bits of perfctr-watchdog.c to > > perf_events.c, modify nmi.c to just register as a normal perf event and > > probably cleanup the oprofile stuff to match, correct? > > > > Cheers, > > Don > > > > As far as I know -- converting perfctr-watchdog.c to into perfevents > style would be quite a desirable feature. But I still didn't manage to > find time for this task :( If you're interested to start this work > -- that would be just great! After looking through the code I just had some questions, perhaps you have thought about this longer than me, what to do with the reservation code (just remove it I assume and let perf_events _be_ the only code that handles perf events) and what to do with some of the cpu quirks as noted in perfctr-watchdog.c (notable some of the Intel errata for the Core chipsets). Cheers, Don