From: Dave Chinner <david@fromorbit.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Tejun Heo" <tj@kernel.org>, "Rafael J. Wysocki" <rjw@sisk.pl>,
"Américo Wang" <xiyou.wangcong@gmail.com>,
"Miles Lane" <miles.lane@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
"Jesse Barnes" <jbarnes@virtuousgeek.org>,
"Len Brown" <len.brown@intel.com>, "Pavel Machek" <pavel@ucw.cz>,
"Arjan van de Ven" <arjan@infradead.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>
Subject: Re: 2.6.33-rc3 -- INFO: possible recursive locking -- (s_active){++++.+}, at: [<c10d2941>] sysfs_hash_and_remove+0x3d/0x4f
Date: Tue, 12 Jan 2010 14:01:34 +1100 [thread overview]
Message-ID: <20100112030134.GA17483@discord.disaster> (raw)
In-Reply-To: <m11vhw6u3k.fsf@fess.ebiederm.org>
On Mon, Jan 11, 2010 at 04:32:31PM -0800, Eric W. Biederman wrote:
> Tejun Heo <tj@kernel.org> writes:
>
> > On 01/11/2010 11:26 AM, Eric W. Biederman wrote:
> >> From: Eric W. Biederman <ebiederm@xmission.com>
> >> Date: Sun, 10 Jan 2010 18:13:35 -0800
> >> Subject: [PATCH] sysfs: Add support for lockdep subclasses to s_active
> >>
> >> We have apparently valid cases where the code for a sysfs attribute
> >> removes other sysfs attributes. Without support for subclasses
> >> lockdep flags a possible recursive lock problem as it figures
> >> the first sysfs attribute could be attempting to remove itself.
> >>
> >> By adding support for sysfs subclasses we can teach lockdep to
> >> distinguish between different types of sysfs attributes and not
> >> get confused.
> >>
> >> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
> >
> > Acked-by: Tejun Heo <tj@kernel.org>
>
> Now if I can just get a Tested-by this patch will be all set ;)
Hi Eric,
Is this the same locking problem that this patch fixes?
http://lkml.org/lkml/2010/1/11/26
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2010-01-12 3:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 12:54 2.6.33-rc3 -- INFO: possible recursive locking -- (s_active){++++.+}, at: [<c10d2941>] sysfs_hash_and_remove+0x3d/0x4f Miles Lane
2010-01-06 13:36 ` Miles Lane
2010-01-10 0:10 ` Arjan van de Ven
2010-01-10 8:47 ` Américo Wang
2010-01-10 8:58 ` Américo Wang
2010-01-10 17:23 ` Eric W. Biederman
2010-01-10 18:35 ` Rafael J. Wysocki
2010-01-11 2:26 ` Eric W. Biederman
2010-01-11 20:18 ` Rafael J. Wysocki
2010-01-12 0:31 ` Tejun Heo
2010-01-12 0:32 ` Eric W. Biederman
2010-01-12 3:01 ` Dave Chinner [this message]
2010-01-12 9:22 ` Eric W. Biederman
[not found] ` <a44ae5cd1001130817v7a3ffbc9yc83d7cc701f8620@mail.gmail.com>
2010-01-13 18:37 ` Eric W. Biederman
2010-01-13 21:11 ` Miles Lane
2010-01-12 14:44 ` Américo Wang
2010-01-14 2:47 ` Miles Lane
2010-01-14 3:09 ` Eric W. Biederman
2010-01-14 9:13 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100112030134.GA17483@discord.disaster \
--to=david@fromorbit.com \
--cc=arjan@infradead.org \
--cc=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=jbarnes@virtuousgeek.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miles.lane@gmail.com \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=rjw@sisk.pl \
--cc=tj@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox