public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dimitrios Apostolou <jimis@gmx.net>, Alex Chiang <achiang@hp.com>,
	Len Brown <lenb@kernel.org>, Bjorn Helgaas <bjorn.helgaas@hp.com>,
	Yinghai Lu <yinghai@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: High cpu temperature with 2.6.32, bisection shows commit 69d258 (fwd)
Date: Tue, 12 Jan 2010 21:32:05 -0800	[thread overview]
Message-ID: <20100112213205.7d74808a@infradead.org> (raw)
In-Reply-To: <20100112160734.89ee6b11.akpm@linux-foundation.org>

On Tue, 12 Jan 2010 16:07:34 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:

> > While testing your patch, indeed the temperature was not rising and 
> > everything was normal, but the tsc was not marked as unstable so it
> > didn't switch to acpi_pm clocksource, so that was probably the
> > reason.
> > 
> 
> Arjan, can you please prepare a formal version of the fix?  I guess
> the cc:stable will be needed as well.

sure see below
> 
> I assume that the effects which Dimitrios described above were the
> intended ones?

yes absolutely; having a stable tsc is a good thing, and totally expected
if you don't have C2.


Subject: Add two laptops to the C-state DMI table
From: Arjan van de Ven <arjan@linux.intel.com>

CC: stable@kernel.org

Since the rewrite of the CPU idle governor in 2.6.32, two laptops have surfaced
where the BIOS advertises a C2 power state, but for some reason this state is not
functioning (as verified in both cases by powertop before the patch in .32).

The old governor had the accidental behavior that if a non-working state was chosen
too many times, it would end up falling back to C1. The new governor works differently
and this accidental behavior is no longer there; the result is a high temperature
on these two machines.

This patch adds these 2 machines to the DMI table for C state anomalies; by just not using
C2 both these machines are better off (the TSC can be used instead of the pm timer, giving
a performance boost for example).

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>



diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index d1676b1..6c3145b 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -110,6 +110,14 @@ static struct dmi_system_id __cpuinitdata processor_power_dmi_table[] = {
 	  DMI_MATCH(DMI_BIOS_VENDOR,"Phoenix Technologies LTD"),
 	  DMI_MATCH(DMI_BIOS_VERSION,"SHE845M0.86C.0013.D.0302131307")},
 	 (void *)2},
+	{ set_max_cstate, "Pavilion zv5000", {
+	  DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+	  DMI_MATCH(DMI_PRODUCT_NAME,"Pavilion zv5000 (DS502A#ABA)")},
+	 (void *)1},
+	{ set_max_cstate, "Asus L8400B", {
+	  DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer Inc."),
+	  DMI_MATCH(DMI_PRODUCT_NAME,"L8400B series Notebook PC")},
+	 (void *)1},
 	{},
 };
 





-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

  reply	other threads:[~2010-01-13  5:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <alpine.LNX.2.00.1001071941470.1363@localhost.localdomain>
2010-01-08 17:15 ` High cpu temperature with 2.6.32, bisection shows commit 69d258 (fwd) Alex Chiang
2010-01-09 21:43   ` Arjan van de Ven
2010-01-09 23:55     ` Dimitrios Apostolou
2010-01-10  0:08       ` Arjan van de Ven
2010-01-10  0:32         ` Dimitrios Apostolou
2010-01-10  0:42           ` Arjan van de Ven
2010-01-10  1:05             ` Dimitrios Apostolou
2010-01-10  1:38               ` Arjan van de Ven
2010-01-13  0:07               ` Andrew Morton
2010-01-13  5:32                 ` Arjan van de Ven [this message]
2010-02-10 20:51                   ` Dimitrios Apostolou
2010-02-10 21:42                     ` Dimitrios Apostolou
2010-02-11  4:56                     ` Arjan van de Ven
2010-02-11 18:00                       ` Dimitrios Apostolou
2010-02-11 21:58                         ` Wojciech Ploskonka
2010-02-12  5:24                           ` Arjan van de Ven
2010-02-12 21:05                             ` Matthew Garrett
2010-02-18 20:27                             ` Dimitrios Apostolou
2010-02-18 20:34                               ` Rafael J. Wysocki
2010-02-22 16:43                             ` Dimitrios Apostolou
2010-02-23  1:55                               ` Arjan van de Ven
2010-02-12  5:23                         ` Arjan van de Ven
2010-01-10  2:07             ` Ray Lee
2010-01-10  3:09               ` Robert Hancock
2010-01-10  4:15               ` Arjan van de Ven
2010-01-15 20:00           ` -O0 kernel " Pavel Machek
2010-01-15 20:40             ` Dimitrios Apostolou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100112213205.7d74808a@infradead.org \
    --to=arjan@infradead.org \
    --cc=achiang@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=jimis@gmx.net \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox