* (no subject)
@ 2010-01-13 0:48 Jeff Mahoney
2010-01-13 10:44 ` [PATCH] hwmon: (smsc47m1) Fix section mismatch Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Mahoney @ 2010-01-13 0:48 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Andrew Morton, Jean Delvare
Subject: [patch 1/6] smsc47m1: Fix section mismatch
References: <20100113004855.550486769@suse.com>
Content-Disposition: inline; filename=patches.rpmify/smsc47m1-fix-section-mismatch
smsc47m1_restore is called from sm_smsc47m1_exit, which is an __exit
function, so it can't be __init.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
drivers/hwmon/smsc47m1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/hwmon/smsc47m1.c
+++ b/drivers/hwmon/smsc47m1.c
@@ -488,7 +488,7 @@ static int __init smsc47m1_find(unsigned
}
/* Restore device to its initial state */
-static void __init smsc47m1_restore(const struct smsc47m1_sio_data *sio_data)
+static void smsc47m1_restore(const struct smsc47m1_sio_data *sio_data)
{
if ((sio_data->activate & 0x01) == 0) {
superio_enter();
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] hwmon: (smsc47m1) Fix section mismatch
2010-01-13 0:48 Jeff Mahoney
@ 2010-01-13 10:44 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2010-01-13 10:44 UTC (permalink / raw)
To: Jeff Mahoney; +Cc: Linux Kernel Mailing List, Andrew Morton
Hi Jeff,
On Tue, 12 Jan 2010 19:48:56 -0500, Jeff Mahoney wrote:
> Subject: [patch 1/6] smsc47m1: Fix section mismatch
> References: <20100113004855.550486769@suse.com>
> Content-Disposition: inline; filename=patches.rpmify/smsc47m1-fix-section-mismatch
>
> smsc47m1_restore is called from sm_smsc47m1_exit, which is an __exit
> function, so it can't be __init.
>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
> ---
> drivers/hwmon/smsc47m1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/hwmon/smsc47m1.c
> +++ b/drivers/hwmon/smsc47m1.c
> @@ -488,7 +488,7 @@ static int __init smsc47m1_find(unsigned
> }
>
> /* Restore device to its initial state */
> -static void __init smsc47m1_restore(const struct smsc47m1_sio_data *sio_data)
> +static void smsc47m1_restore(const struct smsc47m1_sio_data *sio_data)
> {
> if ((sio_data->activate & 0x01) == 0) {
> superio_enter();
>
Good catch, thanks for reporting. I do not get any warning about this
one, even though I build the driver as a module and with hotplug
support enabled. I don't get it.
Anyway, patch applied, thanks.
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-13 10:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-13 0:48 Jeff Mahoney
2010-01-13 10:44 ` [PATCH] hwmon: (smsc47m1) Fix section mismatch Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox