From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Adrian Hunter <adrian.hunter@nokia.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
"Quadros Roger (Nokia-D/Helsinki)" <roger.quadros@nokia.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: Add 'start-up time' to fixed voltage regulators
Date: Wed, 13 Jan 2010 12:26:12 +0000 [thread overview]
Message-ID: <20100113122612.GC27473@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <4B4DB94E.8080602@nokia.com>
On Wed, Jan 13, 2010 at 02:15:10PM +0200, Adrian Hunter wrote:
> Mark Brown wrote:
> >>#include <linux/gpio.h>
> >>+#include <linux/delay.h>
> >I think your MUA may have eaten the patch - it looks like the leading
> >spaces got stripped which is liable to confuse things.
> Are you sure? Looks fines to me.
The above should be
> #include <linux/gpio.h>
> +#include <linux/delay.h>
IIRC ie, a one character indent on the context as well as the changed
lines.
> >startup_delay? Just in case we think of another delay, though I'm
> >struggling to think of one right now so I'm not too worried.
> I am too lazy to change it unless there is something else too ;-)
On the other hand the cross tree issues will be annoying if it's changed
later...
next prev parent reply other threads:[~2010-01-13 12:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 11:58 [PATCH] regulator: Add 'start-up time' to fixed voltage regulators Adrian Hunter
2010-01-13 12:03 ` Mark Brown
2010-01-13 12:15 ` Adrian Hunter
2010-01-13 12:26 ` Mark Brown [this message]
2010-01-13 12:55 ` Adrian Hunter
2010-01-13 13:18 ` Mark Brown
2010-01-13 13:11 ` Adrian Hunter
2010-01-13 13:18 ` Mark Brown
2010-01-14 19:54 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100113122612.GC27473@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=adrian.hunter@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=roger.quadros@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox