From: Scott Smedley <ss@aao.gov.au>
To: Marin Mitov <mitov@issp.bas.bg>
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Yet another dt3155 driver for drivers/staging
Date: Thu, 14 Jan 2010 12:03:36 +1100 [thread overview]
Message-ID: <20100114010335.GB20569@aao.gov.au> (raw)
In-Reply-To: <201001130816.43855.mitov@issp.bas.bg>
Hi Greg & Marin,
> > Scott, any comparison between the two of them as to which one actually
> > works better?
I'd be interested in Marin's opinion as he appears to have used both
drivers extensively.
I'd like a userspace program to actually try out Marin's driver, but
I can still make some general comments:
Things I like about Marin's driver:
- It is only ~1/3rd the size. (by counting new lines)
- The code is much neater.
- It can acquire frames at 25 fps (real-time), according to Marin.
- At least 1 person with intimate knowledge of the code seems keen to
maintain it.
Things I like about the sourceforge (SF) driver:
- It works in CCIR mode (768x576) or 640x480 mode.
- It is well tested.
- It works with most kernel versions. ie. 2.2, 2.4, & 2.6. (mostly)
- It works with multiple boards.
- The code is moderately well commented.
- It includes simple (user space) example programs.
Clearly each driver has strengths over the other.
It would probably be easier to upgrade Marin's driver to match the
strengths of the SF driver than the other way around. The only
difficulty might be in making Marin's driver work with older kernel
versions. IMO, that's probably an acceptable sacrifice to make. (For
users of legacy systems, we could point them to the (unmaintained)
driver on SF.)
> if you have 2 or more boards, could you check if
> my driver is working with more than one board?
Sorry, I only have 1 board available to test with.
Marin, if you are considering upgrading your driver, I propose
we send an email to the DT3155 SF mailing list & ask for help
testing. (I already know of 1 other person who is happy to help
test.) I recommend making userspace programs (like examples/acquire
& examples/Xview in the SF driver) available first. Ideally, these
example programs & user space libraries would become the major
component of the evolved DT3155 SF project.
What do you think?
Scott. :)
next prev parent reply other threads:[~2010-01-14 1:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 20:42 [RFC] Yet another dt3155 driver for drivers/staging Marin Mitov
2010-01-12 23:52 ` Scott Smedley
2010-01-13 0:17 ` Greg KH
2010-01-13 6:16 ` Marin Mitov
2010-01-14 1:03 ` Scott Smedley [this message]
2010-01-14 2:36 ` Greg KH
2010-01-14 3:13 ` Scott Smedley
2010-01-14 3:40 ` Greg KH
2010-01-14 19:39 ` Marin Mitov
2010-01-15 17:33 ` Greg KH
2010-01-14 19:23 ` Marin Mitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114010335.GB20569@aao.gov.au \
--to=ss@aao.gov.au \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mitov@issp.bas.bg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox