From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 3/6] perf: Round robin groups of events using list_rotate_left()
Date: Thu, 14 Jan 2010 13:29:23 +0100 [thread overview]
Message-ID: <20100114122921.GD5033@nowhere> (raw)
In-Reply-To: <1263471922.4244.311.camel@laptop>
On Thu, Jan 14, 2010 at 01:25:22PM +0100, Peter Zijlstra wrote:
> On Sun, 2010-01-10 at 02:38 +0100, Frederic Weisbecker wrote:
> > This is more proper that doing it through a list_for_each_entry()
> > that breaks after the first entry.
> >
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> > Cc: Paul Mackerras <paulus@samba.org>
> > ---
>
> > + list_rotate_left(&ctx->pinned_groups);
> > + list_rotate_left(&ctx->flexible_groups);
>
> Just wondering, pinned events were supposed to be on the pmu at all
> times, right?
Yeah, but the previous version that was using a global
list rotated the whole. So, somehow to keep the same
bahaviour, I also rotate the pinned group, even
if it makes no sense :-)
But there is a subsequent patch in the same set
that removes the rotating of pinned groups.
next prev parent reply other threads:[~2010-01-14 12:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-10 1:38 [PATCH 0/6] perf: Various event scheduling improvements Frederic Weisbecker
2010-01-10 1:38 ` [PATCH 1/6 v2] perf/core: Split context's event group list into pinned and non-pinned lists Frederic Weisbecker
2010-01-10 1:38 ` [PATCH 2/6] list: Introduce list_rotate_left() Frederic Weisbecker
2010-01-10 1:38 ` [PATCH 3/6] perf: Round robin groups of events using list_rotate_left() Frederic Weisbecker
2010-01-14 12:25 ` Peter Zijlstra
2010-01-14 12:29 ` Frederic Weisbecker [this message]
2010-01-14 12:32 ` Peter Zijlstra
2010-01-10 1:38 ` [PATCH 4/6] perf: Export software-only event group characteristic as a flag Frederic Weisbecker
2010-01-10 1:38 ` [PATCH 5/6] perf: Don't rotate pinned groups Frederic Weisbecker
2010-01-10 1:38 ` [PATCH 6/6] perf: Increase round-robin fairness of flexible events Frederic Weisbecker
2010-01-10 22:04 ` Paul Mackerras
2010-01-10 23:57 ` Frederic Weisbecker
2010-01-11 0:39 ` Paul Mackerras
2010-01-11 1:56 ` Frederic Weisbecker
2010-01-14 12:49 ` [PATCH 0/6] perf: Various event scheduling improvements Peter Zijlstra
2010-01-14 13:09 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114122921.GD5033@nowhere \
--to=fweisbec@gmail.com \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox