From: "Venkatesh Pallipadi" <venkatesh.pallipadi@intel.com>
To: "Ingo Molnar" <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Len Brown" <lenb@kernel.org>,
"Mark Hounschell" <markh@compro.net>
Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
"Alain Knaff" <alain@knaff.lu>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Li, Shaohua" <shaohua.li@intel.com>
Subject: [patch 1/4] acpi: acpi_cpu_soft_notify() not getting called on resume
Date: Thu, 14 Jan 2010 17:39:58 -0800 [thread overview]
Message-ID: <20100115014209.844297000@intel.com> (raw)
In-Reply-To: 20100115013957.027452000@intel.com
[-- Attachment #1: 0002-acpi_cpu_soft_notify-seems-to-be-calling-ppc-cst.patch --]
[-- Type: text/plain, Size: 1408 bytes --]
acpi_cpu_soft_notify() seems to be calling ppc, cst and tstate routines
only on CPU_ONLINE and not on CPU_ONLINE_FROZEN, which means these
routines are getting called on logical CPU offline-online but not
getting called for any non-boot CPUs during suspend-resume.
One side effect of this that I noticed is that,
tick_broadcast_mask changes from 0000000f to 00000001 after
suspend-resume. I haven't seen any functionality issue with this. But,
seems wrong. I am not sure whether this can result in any other
bugs/issues. But, here is the fix.
This patch is a pre-requisite for followup patches that tries to fix
clockevent source ratings.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
---
drivers/acpi/processor_core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index 9863c98..4513395 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -695,7 +695,7 @@ static int acpi_cpu_soft_notify(struct notifier_block *nfb,
unsigned int cpu = (unsigned long)hcpu;
struct acpi_processor *pr = per_cpu(processors, cpu);
- if (action == CPU_ONLINE && pr) {
+ if ((action == CPU_ONLINE || action == CPU_ONLINE_FROZEN) && pr) {
acpi_processor_ppc_has_changed(pr, 0);
acpi_processor_cst_has_changed(pr);
acpi_processor_tstate_has_changed(pr);
--
1.6.0.6
--
next prev parent reply other threads:[~2010-01-15 1:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 1:39 [patch 0/4] Only use HPET MSI timers on systems with deep C-state support Venkatesh Pallipadi
2010-01-15 1:39 ` Venkatesh Pallipadi [this message]
2010-01-15 1:39 ` [patch 2/4] x86: Do not use hpet MSI as clockevent broadcast device Venkatesh Pallipadi
2010-01-15 2:00 ` H. Peter Anvin
2010-01-15 2:07 ` Pallipadi, Venkatesh
2010-01-15 1:40 ` [patch 3/4] clockevent: Add tick_check_fallback_timer to look for fallback timer Venkatesh Pallipadi
2010-01-15 1:40 ` [patch 4/4] x86: Adjust HPET MSI timer rating to work with tick_check_fallback_timer Venkatesh Pallipadi
2010-01-15 21:53 ` [patch 0/4] Only use HPET MSI timers on systems with deep C-state support Mark Hounschell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100115014209.844297000@intel.com \
--to=venkatesh.pallipadi@intel.com \
--cc=alain@knaff.lu \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=shaohua.li@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox