public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Li Zefan <lizf@cn.fujitsu.com>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 2/8] ftrace: Fix MATCH_END_ONLY function filter
Date: Thu, 14 Jan 2010 22:57:28 -0500	[thread overview]
Message-ID: <20100115035852.463842164@goodmis.org> (raw)
In-Reply-To: 20100115035726.462940848@goodmis.org

[-- Attachment #1: 0002-ftrace-Fix-MATCH_END_ONLY-function-filter.patch --]
[-- Type: text/plain, Size: 1337 bytes --]

From: Li Zefan <lizf@cn.fujitsu.com>

For '*foo' pattern, we should allow any string ending with
'foo', but ftrace filter incorrectly disallows strings
like bar_foo_foo:

  # echo '*io' > set_ftrace_filter
  # cat set_ftrace_filter | grep 'req_bio_endio'
  # cat available_filter_functions | grep 'req_bio_endio'
  req_bio_endio

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
LKML-Reference: <4B4E870E.6060607@cn.fujitsu.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/trace/ftrace.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 7968762..1e6640f 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -1690,7 +1690,7 @@ ftrace_regex_lseek(struct file *file, loff_t offset, int origin)
 static int ftrace_match(char *str, char *regex, int len, int type)
 {
 	int matched = 0;
-	char *ptr;
+	int slen;
 
 	switch (type) {
 	case MATCH_FULL:
@@ -1706,8 +1706,8 @@ static int ftrace_match(char *str, char *regex, int len, int type)
 			matched = 1;
 		break;
 	case MATCH_END_ONLY:
-		ptr = strstr(str, regex);
-		if (ptr && (ptr[len] == 0))
+		slen = strlen(str);
+		if (slen >= len && memcmp(str + slen - len, regex, len) == 0)
 			matched = 1;
 		break;
 	}
-- 
1.6.5



  parent reply	other threads:[~2010-01-15  3:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-15  3:57 [PATCH 0/8][GIT PULL][v2.6.33] tracing: fixes Steven Rostedt
2010-01-15  3:57 ` [PATCH 1/8] tracing/x86: Derive arch from bits argument in recordmcount.pl Steven Rostedt
2010-01-15  3:57 ` Steven Rostedt [this message]
2010-01-15  3:57 ` [PATCH 3/8] tracing/filters: Fix MATCH_FRONT_ONLY filter matching Steven Rostedt
2010-01-15  3:57 ` [PATCH 4/8] tracing/filters: Fix MATCH_END_ONLY " Steven Rostedt
2010-01-15  3:57 ` [PATCH 5/8] lib: Introduce strnstr() Steven Rostedt
2010-01-15  3:57 ` [PATCH 6/8] tracing/filters: Fix MATCH_MIDDLE_ONLY filter matching Steven Rostedt
2010-01-15  3:57 ` [PATCH 7/8] tracing/filters: Fix MATCH_FULL filter matching for PTR_STRING Steven Rostedt
2010-01-15  3:57 ` [PATCH 8/8] tracing/filters: Add comment for match callbacks Steven Rostedt
2010-01-16  6:56 ` [PATCH 0/8][GIT PULL][v2.6.33] tracing: fixes Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100115035852.463842164@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox