Re: serial_cs: oxsemi quirk breaks resume

[Pavel Machek <pavel@ucw.cz>]

On Tue 2009-11-10 08:54:10, Pavel Machek wrote:
> 
> Quirk is applied on all cards with given manfid (is it that
> correct?). Unfortunately, that quirk breaks resume on zaurus with
> billionton bluetooth card inserted: c950ctrl is 0 and outb() faults.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

I believe this patch got enough acks and is waiting in the tree
somewhere (greg?) (possibly with slightly different changelog), but I
don't see it in 33-rc4. Could it get pushed? It is quite simple
bugfix, and is important for my zaurus...  Pavel

> --- a/drivers/serial/serial_cs.c	2009-10-06 13:51:46.000000000 +0200
> +++ b/drivers/serial/serial_cs.c	2009-11-09 14:43:25.000000000 +0100
> @@ -158,7 +158,8 @@
>  {
>  	struct serial_info *info = link->priv;
>  
> -	outb(12, info->c950ctrl + 1);
> +	if (info->c950ctrl)
> +		outb(12, info->c950ctrl + 1);
>  }
>  
>  /* request_region? oxsemi branch does no request_region too... */
> 
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html